gh-103592: Add tests of Literal with Enum and Union of Literals#103706
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sobolevn requested review from AlexWaygood, Fidget-Spinner, JelleZijlstra and gvanrossum as code owners
JelleZijlstra approved these changes Apr 23, 2023
AlexWaygood approved these changes Apr 23, 2023
Contributor
miss-islington commented Apr 23, 2023
Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 23, 2023
…iteral`s (pythonGH-103706) (cherry picked from commit 5041c2b) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
bedevere-bot commented Apr 23, 2023
GH-103720 is a backport of this pull request to the 3.11 branch. |
Member
AlexWaygood commented Apr 23, 2023
@sobolevn, are you up for backporting these tests to |
AlexWaygood pushed a commit that referenced this pull request Apr 23, 2023
MemberAuthor
Now I realized that I've missed @AlexWaygood Yeah, sure. Will do tomorrow. |
This was referenced Apr 24, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests should catch theoretical future regressions similar to ones described in #103592
Union[Literal[1], Literal[SomeEnum.one]]#103592