[NO ISSUE] Adds __eq__ support for non-normalized fractions#103959
Closed
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a fraction is created with the
_normalizeparameter set to false, it fill fail equality checks it should not.For example before this fix:
Fraction(4,2,_normalize=False) != 2.This PR changes the equality check from just checking that the comparison int equals the numerator to checking that numerator/denominator is equal to the int.