Skip to content

Conversation

@iritkatriel
Copy link
Member

@iritkatrieliritkatriel commented May 1, 2023

@ammaraskar
Copy link
Member

I think this does fix the issue for now since the deprecation PR adds aliases in the sre_* files (https://github.com/python/cpython/blob/1be3260a90f16aae334d993aecf7b70426f98013/Lib/sre_compile.py)

Longer term we should change this so it directly imports compile from the re module and error from re._constants

@iritkatrieliritkatriel added skip news tests Tests in the Lib/test dir labels May 1, 2023
@iritkatrieliritkatriel merged commit 81fc135 into python:mainMay 5, 2023
carljm added a commit to carljm/cpython that referenced this pull request May 5, 2023
* main: (61 commits) pythongh-64595: Argument Clinic: Touch source file if any output file changed (python#104152) pythongh-64631: Test exception messages in cloned Argument Clinic funcs (python#104167) pythongh-68395: Avoid naming conflicts by mangling variable names in Argument Clinic (python#104065) pythongh-64658: Expand Argument Clinic return converter docs (python#104175) pythonGH-103092: port `_asyncio` freelist to module state (python#104196) pythongh-104051: fix crash in test_xxtestfuzz with -We (python#104052) pythongh-104190: fix ubsan crash (python#104191) pythongh-104106: Add gcc fallback of mkfifoat/mknodat for macOS (pythongh-104129) pythonGH-104142: Fix _Py_RefcntAdd to respect immortality (pythonGH-104143) pythongh-104112: link from cached_property docs to method-caching FAQ (python#104113) pythongh-68968: Correcting message display issue with assertEqual (python#103937) pythonGH-103899: Provide a hint when accidentally calling a module (pythonGH-103900) pythongh-103963: fix 'make regen-opcode' in out-of-tree builds (python#104177) pythongh-102500: Add PEP 688 and 698 to the 3.12 release highlights (python#104174) pythonGH-81079: Add case_sensitive argument to `pathlib.Path.glob()` (pythonGH-102710) pythongh-91896: Deprecate collections.abc.ByteString (python#102096) pythongh-99593: Add tests for Unicode C API (part 2) (python#99868) pythongh-102500: Document PEP 688 (python#102571) pythongh-102500: Implement PEP 688 (python#102521) pythongh-96534: socketmodule: support FreeBSD divert(4) socket (python#96536) ...
jbower-fb pushed a commit to jbower-fb/cpython that referenced this pull request May 8, 2023
@iritkatrieliritkatriel deleted the fuzztest branch July 25, 2023 18:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

crash in ./python.exe -We -m test -v test_xxtestfuzz

3 participants

@iritkatriel@ammaraskar@bedevere-bot