Skip to content

gh-104057: Fix direct invocation of test_support#104069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zware merged 1 commit into from
May 11, 2023
Merged

gh-104057: Fix direct invocation of test_support #104069

zware merged 1 commit into from
May 11, 2023

Conversation

@Eclips4
Copy link
Member

@Eclips4Eclips4 commented May 1, 2023•
edited by bedevere-bot
Loading

./pythonLib/test/test_support.pyRunningDebug|x64interpreter... .....................s.F......s.........s... ======================================================================FAIL: test_ignored_deprecations_are_silent (__main__.TestSupport.test_ignored_deprecations_are_silent) Testsupport.ignore_deprecations_from() silenceswarnings----------------------------------------------------------------------Traceback (mostrecentcalllast): File"C:\Users\KIRILL-1\CLionProjects\cpython\Lib\test\test_support.py", line52, intest_ignored_deprecations_are_silentself.assertEqual(len(messages), 0, messages) AssertionError: 1!=0 : ['You should NOT be seeing this.'] ----------------------------------------------------------------------Ran44testsin8.697sFAILED (failures=1, skipped=3)

However, there's an another bug with test_make_bad_fd (only on Windows) but it's not related.

@bedevere-botbedevere-bot mentioned this pull request May 1, 2023
Closed
@bedevere-botbedevere-bot added the tests Tests in the Lib/test dir label May 1, 2023
@AlexWaygoodAlexWaygood changed the title gh-104057: Fix direct invocatoin of test_supportgh-104057: Fix direct invocation of test_supportMay 1, 2023
@furkanonder
Copy link
Contributor

furkanonder commented May 2, 2023

LGTM.

@zwarezware merged commit 27419a7 into python:mainMay 11, 2023
carljm added a commit to carljm/cpython that referenced this pull request May 11, 2023
@carljm
Merge branch 'main' into supermon
fb47955
* main: pythongh-104057: Fix direct invocation of test_support (pythonGH-104069) pythongh-87729: improve hit rate of LOAD_SUPER_ATTR specialization (python#104270) pythongh-101819: Fix inverted debug preprocessor check in winconsoleio.c (python#104388)
@Eclips4Eclips4 deleted the fix_test_support branch May 12, 2023 07:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@furkanonderfurkanonderfurkanonder approved these changes

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Eclips4@furkanonder@zware@bedevere-bot@AlexWaygood