GH-103247: bypass the import cache on the _require_loader helper#104186
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This is not a fix for the importlib test monkeypatching leakage but it's something that we probably should be doing anyway. Signed-off-by: Filipe Laíns <lains@riseup.net>
FFY00 requested review from brettcannon, encukou, ericsnowcurrently, ncoghlan and warsaw as code owners
MemberAuthor
FFY00 commented May 5, 2023
cc @JelleZijlstra as the original reporter |
brettcannon approved these changes May 10, 2023
sunmy2019 approved these changes May 10, 2023
MemberAuthor
FFY00 commented Aug 24, 2023
It seems this fell off mental work pool and I only noticed it now. Since we have approvals, I am gonna update the branch and schedule it for merging. |
Member
carljm commented Aug 30, 2023
Bisection shows that the merge of this PR introduced a reference leak in |
MemberAuthor
FFY00 commented Aug 30, 2023
@carljm thanks for the catch, let's revert then. |
Member
carljm commented Aug 30, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not a fix for the importlib test monkeypatching leakage but it's something that we probably should be doing anyway.