gh-101819: Adapt _io.PyWindowsConsoleIO_Type to heap type

[erlend-aasland]

• Issue: Isolate the _io extension module #101819

[vstinner]

Is it a draft or ready for review?

[vstinner]

FAIL: test_no_memleak (test.test_embed.MiscTests.test_no_memleak) (frozen_modules='on', stmt='import __hello__') ---------------------------------------------------------------------- Traceback (most recent call last): File "D:\a\cpython\cpython\Lib\test\test_embed.py", line 1802, in test_no_memleak self.assertEqual(refs, 0, out) AssertionError: 512 != 0 : [512 refs, 302 blocks] 

It seems like there is leak somewhere.

[vstinner]

test_winconsoleio crashed (Exit code 3) -- running: test_multiprocessing_spawn (2 min 47 sec) A�s�s�e�r�t�i�o�n� �f�a�i�l�e�d�:� �P�y�O�b�j�e�c�t�_�T�y�p�e�C�h�e�c�k�(�s�e�l�f�,� �(�P�y�T�y�p�e�O�b�j�e�c�t� �*�)�&�P�y�W�i�n�d�o�w�s�C�o�n�s�o�l�e�I�O�_�T�y�p�e�)�,� �f�i�l�e� �D�:�\�a�\�c�p�y�t�h�o�n�\�c�p�y�t�h�o�n�\�M�o�d�u�l�e�s�\�_�i�o�\�w�i�n�c�o�n�s�o�l�e�i�o�.�c�,� �l�i�n�e� �2�6�8� �Fatal Python error: Aborted 

There are still some test failures. Tell me if you need my help to debug that next week.

[erlend-aasland]

Is it a draft or ready for review?

Draft! I don't have a Windows dev environment set up, so I rely on the CI for these changes.

[bedevere-bot]

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 7c9065f 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

[bedevere-bot]

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit cf81d43 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

[erlend-aasland]

Why isn't the Windows ref leaks bots part of the refleak portion of the fleet?

[vstinner]

Review after merge: LGTM, but the #ifdef around assert() is wrong IMO.