Skip to content

Conversation

@ericsnowcurrently
Copy link
Member

@ericsnowcurrentlyericsnowcurrently commented May 5, 2023

Here we are doing no more than adding the value for Py_mod_multiple_interpreters. We will start checking for it in gh-104206 (once PyInterpreterState.ceval.own_gil is added in gh-104204).

@erlend-aasland
Copy link
Contributor

FYI, there are now two NEWS entries in this PR.

@ericsnowcurrently
Copy link
MemberAuthor

Yeah, one is from gh-104148.

@ericsnowcurrentlyericsnowcurrentlyforce-pushed the per-interpreter-gil-extension-check branch 2 times, most recently from 532330d to a1b027aCompareMay 5, 2023 20:21
@ericsnowcurrentlyericsnowcurrently enabled auto-merge (squash) May 5, 2023 20:27
@ericsnowcurrently
Copy link
MemberAuthor

Sorry for any noise here. I realized it would be better to add Py_MOD_PER_INTERPRETER_GIL_SUPPORTED now, while we wait for gh-104204.

@ericsnowcurrentlyericsnowcurrently enabled auto-merge (squash) May 5, 2023 20:34
@ericsnowcurrentlyericsnowcurrently merged commit a9c6e06 into python:mainMay 5, 2023
@ericsnowcurrentlyericsnowcurrently deleted the per-interpreter-gil-extension-check branch May 5, 2023 21:12
carljm added a commit to carljm/cpython that referenced this pull request May 5, 2023
* main: pythongh-99113: Add PyInterpreterConfig.own_gil (pythongh-104204) pythongh-104146: Remove unused var 'parser_body_declarations' from clinic.py (python#104214) pythongh-99113: Add Py_MOD_PER_INTERPRETER_GIL_SUPPORTED (pythongh-104205) pythongh-104108: Add the Py_mod_multiple_interpreters Module Def Slot (pythongh-104148) pythongh-99113: Share the GIL via PyInterpreterState.ceval.gil (pythongh-104203) pythonGH-100479: Add `pathlib.PurePath.with_segments()` (pythonGH-103975) pythongh-69152: Add _proxy_response_headers attribute to HTTPConnection (python#26152) pythongh-103533: Use PEP 669 APIs for cprofile (pythonGH-103534) pythonGH-96803: Add three C-API functions to make _PyInterpreterFrame less opaque for users of PEP 523. (pythonGH-96849)
ericsnowcurrently added a commit that referenced this pull request May 6, 2023
…4206) Py_MOD_PER_INTERPRETER_GIL_SUPPORTED is a new supported value for Py_mod_multiple_interpreters, added in gh-104205.
jbower-fb pushed a commit to jbower-fb/cpython that referenced this pull request May 8, 2023
…4205) Here we are doing no more than adding the value for Py_mod_multiple_interpreters and using it for stdlib modules. We will start checking for it in pythongh-104206 (once PyInterpreterState.ceval.own_gil is added in pythongh-104204).
jbower-fb pushed a commit to jbower-fb/cpython that referenced this pull request May 8, 2023
…ythongh-104206) Py_MOD_PER_INTERPRETER_GIL_SUPPORTED is a new supported value for Py_mod_multiple_interpreters, added in pythongh-104205.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ericsnowcurrently@erlend-aasland@bedevere-bot