Skip to content

Conversation

@barneygale
Copy link
Contributor

@barneygalebarneygale commented May 7, 2023

  • Split pathlib.Path into _AbstractPath and Path
    • Make _AbstractPath.stat(), open() and iterdir() abstract
    • Implement _AbstractPath._scandir() via iterdir()
      • Add follow_symlinks argument to is_dir() for consistency with os.DirEntry.is_dir()
      • Use context manager enter value in walk() to enable use of a contextlib.nullcontext()
    • Implement _AbstractPath.is_mount() and is_junction() using stat(), restoring implementation from before gh-86943: implement pathlib.WindowsPath.is_mount() #31458 in the former case.
  • [more to come!]

@barneygale
Copy link
ContributorAuthor

Closing - will log a fresh PR soon :)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@barneygale@bedevere-bot