Skip to content

Conversation

@AlexWaygood
Copy link
Member

@AlexWaygoodAlexWaygood commented May 12, 2023


📚 Documentation preview 📚: https://cpython-previews--104422.org.readthedocs.build/

@bedevere-botbedevere-bot added the docs Documentation in the Doc dir label May 12, 2023
@AlexWaygoodAlexWaygood changed the title gh-102500: Fixup some docs issues following ByteString deprecationgh-91896: Fixup some docs issues following ByteString deprecationMay 12, 2023
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Copy link
Member

@JelleZijlstraJelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to get this merged so we can get CI green, but we should consider whether the import * case is important enough to drop the warning. This would be annoying:

% ./python.exe -Werr Python 3.12.0a7+ (heads/tvobject-dirty:bc3757969b, May 12 2023, 06:50:26) [Clang 14.0.0 (clang-1400.0.29.202)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>> from typing import * Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/Users/jelle/py/cpython/Lib/typing.py", line 3328, in __getattr__ warnings._deprecated("typing.ByteString", remove=(3, 14)) File "/Users/jelle/py/cpython/Lib/warnings.py", line 529, in _deprecated warn(msg, DeprecationWarning, stacklevel=3) DeprecationWarning: 'typing.ByteString' is deprecated and slated for removal in Python 3.14 >>> 

@AlexWaygoodAlexWaygood merged commit ce4eecf into python:mainMay 12, 2023
carljm added a commit to carljm/cpython that referenced this pull request May 12, 2023
* main: pythongh-91896: Fixup some docs issues following ByteString deprecation (python#104422) pythonGH-104371: check return value of calling `mv.release` (python#104417) pythongh-104415: Fix refleak tests for `typing.ByteString` deprecation (python#104416) pythonGH-86275: Implementation of hypothesis stubs for property-based tests, with zoneinfo tests (python#22863) pythonGH-103082: Filter LINE events in VM, to simplify tool implementation. (pythonGH-104387) pythongh-93649: Split gc- and allocation tests from _testcapimodule.c (pythonGH-104403) pythongh-104389: Add 'unused' keyword to Argument Clinic C converters (python#104390) pythongh-101819: Prepare _io._IOBase for module state (python#104386) pythongh-104413: Fix refleak when super attribute throws AttributeError (python#104414) Fix refleak in `super_descr_get` (python#104408) pythongh-87526: Remove dead initialization from _zoneinfo parse_abbr() (python#24700) pythongh-91896: Improve visibility of `ByteString` deprecation warnings (python#104294) pythongh-104371: Fix calls to `__release_buffer__` while an exception is active (python#104378) pythongh-104377: fix cell in comprehension that is free in outer scope (python#104394) pythongh-104392: Remove _paramspec_tvars from typing (python#104393) pythongh-104396: uuid.py to skip platform check for emscripten and wasi (pythongh-104397) pythongh-99108: Refresh HACL* from upstream (python#104401) pythongh-104301: Allow leading whitespace in disambiguated pdb statements (python#104342)
@AlexWaygoodAlexWaygood deleted the more-bytestring-deprecations branch May 12, 2023 18:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.12only security fixesdocsDocumentation in the Doc dirskip newstopic-typing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexWaygood@JelleZijlstra@bedevere-bot