gh-104146: Purge dead code from Argument Clinic#104680
Uh oh!
There was an error while loading. Please reload this page.
Conversation
The following local variables were assigned but never used: - line 551: result - line 1341: groups - line 1431: default_return_converter - line 1529: ignore_self - line 1809: input_checksum - line 4224: new'
Tools/clinic/clinic.py Outdated
| defdirective_module(self, name): | ||
| fields=name.split('.') | ||
| new=fields.pop() | ||
| fields=name.split('.')[1:] |
There was a problem hiding this comment.
pop() removes the last item in the list, no?
| fields=name.split('.')[1:] | |
| fields=name.split('.')[:-1] |
There was a problem hiding this comment.
Good catch. Yes, [1:] is definitely wrong. Strangely, make clinic does not complain or generate incorrect.
AlexWaygood commented May 20, 2023
Would you be interested in possibly running pyflakes on Tools/clinic/ in CI, to catch this kind of thing in the future? It's a linter that tries extremely hard to have 0 false positives, and didn't have any hits on Tools/clinic/ other than the ones that are being fixed here |
erlend-aasland commented May 20, 2023
I think that's a good idea. Others might disagree :) |
AlexWaygood commented May 20, 2023
I can open an issue and we can see if anybody objects! |
Uh oh!
There was an error while loading. Please reload this page.
3 participants
The following local variables were assigned but never used: