Skip to content

gh-104683: clinic.py: Modernise parse_converter() using pattern-matching#104696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AlexWaygood merged 3 commits into from
May 21, 2023
Merged

gh-104683: clinic.py: Modernise parse_converter() using pattern-matching #104696

AlexWaygood merged 3 commits into from
May 21, 2023

Conversation

@AlexWaygood
Copy link
Member

@AlexWaygoodAlexWaygood commented May 20, 2023•
edited by bedevere-bot
Loading

And add type hints while we're here

@bedevere-botbedevere-bot mentioned this pull request May 20, 2023
Closed
7 tasks
erlend-aasland
erlend-aasland approved these changes May 20, 2023
View reviewed changes
Copy link
Contributor

@erlend-aaslanderlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

AlexWaygood
AlexWaygood commented May 20, 2023
View reviewed changes
@erlend-aasland
Copy link
Contributor

erlend-aasland commented May 20, 2023

Oh, before you land, could you please check that we've got coverage for those branches?

AlexWaygood
AlexWaygood commented May 21, 2023
View reviewed changes
@AlexWaygoodAlexWaygood mentioned this pull request May 21, 2023
Merged
@AlexWaygood
Copy link
MemberAuthor

AlexWaygood commented May 21, 2023

Test cases have been added in #104729 for the branches missing coverage.

@AlexWaygoodAlexWaygood enabled auto-merge (squash) May 21, 2023 23:04
@AlexWaygoodAlexWaygood merged commit 4b107d8 into python:mainMay 21, 2023
@erlend-aasland
Copy link
Contributor

erlend-aasland commented May 22, 2023

Very nice improvement!

@AlexWaygoodAlexWaygood deleted the clinic-parse_converter branch May 22, 2023 06:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@sunmy2019sunmy2019sunmy2019 approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AlexWaygood@erlend-aasland@sunmy2019@bedevere-bot