Skip to content

gh-104698: Fix reference leak in mmapmodule.c#104700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pablogsal merged 5 commits into from
May 21, 2023
Merged

gh-104698: Fix reference leak in mmapmodule.c #104700

pablogsal merged 5 commits into from
May 21, 2023

Conversation

@Eclips4
Copy link
Member

@Eclips4Eclips4 commented May 20, 2023•
edited by bedevere-bot
Loading

Since macro CHECK_VALID need to redesigned to solve this error, I decided to write new macro CHECK_VALID_AND_RELEASE, which behave the same as CHECK_VALID, but also release a buffer.

@bedevere-botbedevere-bot mentioned this pull request May 20, 2023
Closed
@Eclips4
Copy link
MemberAuthor

Eclips4 commented May 20, 2023•
edited
Loading

сс @sunmy2019@chgnrdv

sunmy2019
sunmy2019 reviewed May 20, 2023
View reviewed changes
@JelleZijlstraJelleZijlstra added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label May 20, 2023
@bedevere-bot
Copy link

bedevere-bot commented May 20, 2023

🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit a4341c7 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label May 20, 2023
JelleZijlstra
JelleZijlstra reviewed May 20, 2023
View reviewed changes
Copy link
Member

@JelleZijlstraJelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Two small suggestions.

@pablogsalpablogsal merged commit 99b6418 into python:mainMay 21, 2023
@pablogsal
Copy link
Member

pablogsal commented May 21, 2023

Mergin to fix the refleak buildbots and reduce the noise in main. Thanks for the PR @Eclips4 !

@pablogsalpablogsal added the needs backport to 3.11 only security fixes label May 21, 2023
@miss-islington
Copy link
Contributor

miss-islington commented May 21, 2023

Thanks @Eclips4 for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented May 21, 2023

GH-104710 is a backport of this pull request to the 3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label May 21, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2023
@Eclips4@JelleZijlstra@miss-islington
pythongh-104698: Fix reference leak in mmapmodule.c (pythonGH-104700)
914dbdc
(cherry picked from commit 99b6418) Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
JelleZijlstra added a commit that referenced this pull request May 21, 2023
@miss-islington@Eclips4@JelleZijlstra
[3.11]gh-104698: Fix reference leak in mmapmodule.c (GH-104700) (#10…
b2e0201
…4710) (cherry picked from commit 99b6418) Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@Eclips4Eclips4 deleted the issue-104698 branch May 21, 2023 06:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra left review comments

@sunmy2019sunmy2019sunmy2019 left review comments

@pablogsalpablogsalpablogsal approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Eclips4@bedevere-bot@pablogsal@miss-islington@JelleZijlstra@sunmy2019