Skip to content

Conversation

@mgmacias95
Copy link
Contributor

@mgmacias95mgmacias95 commented May 21, 2023

@AlexWaygood
Copy link
Member

I was wondering if you could do something like this:

_deprecated_objects={"group": lambda*choices: '('+'|'.join(choices) +')', "any": lambda*choices: group(*choices) +'*', "maybe": lambda*choices: group(*choices) +'?', "Whitespace": r'[ \f\t]*', # etc. }

And then at the end of the file have:

def__getattr__(name): ifnamein_deprecated_objects: importwarningswarnings._deprecated( f"tokenize.{name}", message=( "{name} is untested, undocumented, and deprecated. ""It will be removed in Python{remove}." ), remove=(3, 14) ) obj=globals()[name] =_deprecated_objects[name] returnobjraiseAttributeError(f"module 'tokenize' has no attribute '{name}'")

But I will defer to you and @pablogsal as to whether that's a good idea or not.

@AlexWaygood
Copy link
Member

Looks like this does fix the immediate issue, though -- IDLE is once again able to open .py files 🎉

@pablogsal
Copy link
Member

pablogsal commented May 21, 2023

But I will defer to you and @pablogsal as to whether that's a good idea or not.

For the time being, let's just scope this PR to restoring the constants and let's keep the discussion open in the main issue. Also, let's wait until @Yhg1s mentions what he would prefer. Among other things I can imagine an outcome when we promote these to public interface.

@AlexWaygood
Copy link
Member

For the time being, let's just scope this PR to restoring the constants and let's keep the discussion open in the main issue. Also, let's wait until @Yhg1s mentions what he would prefer. Among other things I can imagine an outcome when we promote these to public interface.

SGTM.

@mgmacias95mgmacias95 deleted the restore_tokenize branch May 21, 2023 16:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@mgmacias95@AlexWaygood@pablogsal@bedevere-bot