gh-104764: Skip failing tests in test_enum that started failing.#104765
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… was bumped to 3.13.
Member
Eclips4 commented May 22, 2023
Nit: maybe use a |
MemberAuthor
Yhg1s commented May 22, 2023
I don't know if they are expected, or why it wasn't using unittest.unexpectedFailure before, or what version they should be checking. I just want to get CI green after the version bump. |
JelleZijlstra approved these changes May 22, 2023
Member
JelleZijlstra left a comment
JelleZijlstra left a comment There was a problem hiding this comment.
Let's merge this now to get CI green, we can adjust these tests later.
vstinner approved these changes May 22, 2023
Member
vstinner left a comment
vstinner left a comment There was a problem hiding this comment.
LGTM. But the enum maintainer may consider to change the default behavior or the tests to make it better.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip failing tests in test_enum that started failing when the version was bumped to 3.13.