Skip to content

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commented May 23, 2023

Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files haven't been completely cleaned of old docs warnings, so we don't let them warn on the CI, but now is a good time to prevent creating new warnings:

diff --git a/Doc/whatsnew/2.6.rst b/Doc/whatsnew/2.6.rst index 84bb651e68..7236e1cad7 100644 --- a/Doc/whatsnew/2.6.rst+++ b/Doc/whatsnew/2.6.rst@@ -2465,7 +2465,7 @@ changes, or look through the Subversion logs for all the details. (All changes contributed by Lars Gustäbel). * An optional ``timeout`` parameter was added to the - :class:`telnetlib.Telnet` class constructor, specifying a timeout+ :class:`!telnetlib.Telnet` class constructor, specifying a timeout measured in seconds. (Added by Facundo Batista.) * The :class:`tempfile.NamedTemporaryFile` class usually deletes diff --git a/Doc/whatsnew/3.6.rst b/Doc/whatsnew/3.6.rst index 3a681754e2..1cd33dfb60 100644 --- a/Doc/whatsnew/3.6.rst+++ b/Doc/whatsnew/3.6.rst@@ -1520,7 +1520,7 @@ rather than the version that is being emulated for the process telnetlib --------- -:class:`~telnetlib.Telnet` is now a context manager (contributed by+:class:`!telnetlib.Telnet` is now a context manager (contributed by Stéphane Wirtel in :issue:`25485`). diff --git a/Misc/NEWS.d/3.9.0a1.rst b/Misc/NEWS.d/3.9.0a1.rst index 0888a5c430..7da4385973 100644 --- a/Misc/NEWS.d/3.9.0a1.rst+++ b/Misc/NEWS.d/3.9.0a1.rst@@ -99,7 +99,7 @@ after whitespace, e.g. '127.0.0.1 whatever'. Adds audit events for :mod:`ensurepip`, :mod:`ftplib`, :mod:`glob`, :mod:`imaplib`, :mod:`nntplib`, :mod:`pdb`, :mod:`poplib`, :mod:`shutil`, -:mod:`smtplib`, :mod:`sqlite3`, :mod:`subprocess`, :mod:`telnetlib`,+:mod:`smtplib`, :mod:`sqlite3`, :mod:`subprocess`, :mod:`!telnetlib`, :mod:`tempfile` and :mod:`webbrowser`, as well as :func:`os.listdir`, :func:`os.scandir` and :func:`breakpoint`. 

@vstinner
Copy link
MemberAuthor

I didn't know the !telnetlib syntax in Sphinx. I modified my PR to use this style and I added a reference to PEP 594.

@vstinner
Copy link
MemberAuthor

According to a search on import telnetlib|from telnetlib regex on PyPI top 5,000 projects (2023-04-13), the following projects use telnetlib.

Affected projects (15):

  • ansible (7.4.0)
  • bandit (1.7.5)
  • bflb-iot-tool (1.8.4)
  • boto (2.49.0)
  • gevent (22.10.2)
  • gsutil (5.23)
  • homeassistant (2023.4.3)
  • junos-eznc (2.6.7)
  • mercurial (6.4.1)
  • mobly (1.12.1)
  • mozrunner (8.2.1)
  • netmiko (4.1.2)
  • pudb (2022.1.3)
  • robotframework (6.0.2)
  • ruff (0.0.261)

@vstinnervstinner enabled auto-merge (squash) May 23, 2023 06:56
@vstinnervstinner merged commit 9dc476b into python:mainMay 23, 2023
@vstinnervstinner deleted the remove_telnetlib branch May 23, 2023 07:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner@gpshead@hugovk@bedevere-bot