Skip to content

Conversation

@terryjreedy
Copy link
Member

@terryjreedyterryjreedy commented May 23, 2023

For test_widgets.MenuTest.test_configure_type, the options in the error message change to alphabetical order.

For test_widgets.MenuTest.test_configure_type, the options in the error message change to alphabetical order.
@terryjreedy
Copy link
MemberAuthor

@chrstphrchvz please verify that this passes on 8.7.

@serhiy-storchaka I presume a root.destroy call is needed rather than merely deleting the python binding. If another test in the file ever needs a fix for 8.7 or 9.0, etc., fetching tk_version could be moved to the top of the file, or I could do so now if you prefer.

@terryjreedy
Copy link
MemberAuthor

@chrstphrchvz Please verify that this run without error on 8.7.

@serhiy-storchaka If tk_ver were someday needed for another test, it could be moved to module level. I can do so now if you want.

I presume that explicit root.destroy is needed before exiting the function.

Copy link
Contributor

@chrstphrchvzchrstphrchvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that the test passes on Tk 8.7 with this change.

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use widget.info_patchlevel() in 3.11+, or test.test_tkinter.support.tcl_version or test.test_tkinter.support.get_tk_patchlevel() in older versions.

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@terryjreedyterryjreedy enabled auto-merge (squash) May 27, 2023 19:03
@terryjreedy
Copy link
MemberAuthor

This PR was written specifically as it is because this was the only known test failure when written. #104855 and #104856 report more is test_widget and widget_test. I will later list the alternatives I see in the first of those issues.

@miss-islington
Copy link
Contributor

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-105028 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 27, 2023
* pythongh-104497: Make tkinter test pass with tk 8.7 For test_widgets.MenuTest.test_configure_type, the options in the error message change to alphabetical order. * Update Lib/test/test_tkinter/test_widgets.py Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> --------- (cherry picked from commit 897e716) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-botbedevere-bot removed the needs backport to 3.12 only security fixes label May 27, 2023
@bedevere-bot
Copy link

GH-105029 is a backport of this pull request to the 3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label May 27, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 27, 2023
* pythongh-104497: Make tkinter test pass with tk 8.7 For test_widgets.MenuTest.test_configure_type, the options in the error message change to alphabetical order. * Update Lib/test/test_tkinter/test_widgets.py Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> --------- (cherry picked from commit 897e716) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
terryjreedy added a commit that referenced this pull request May 27, 2023
…5028) For test_widgets.MenuTest.test_configure_type, the options in the error message change to alphabetical order. --------- (cherry picked from commit 897e716) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
terryjreedy added a commit that referenced this pull request May 27, 2023
…5029) For test_widgets.MenuTest.test_configure_type, the options in the error message change to alphabetical order. --------- (cherry picked from commit 897e716) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@terryjreedyterryjreedy deleted the tkalpha branch May 27, 2023 21:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@terryjreedy@miss-islington@bedevere-bot@serhiy-storchaka@chrstphrchvz