Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 33.9k
gh-104497: Make tkinter test pass with tk 8.7#104789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
terryjreedy commented May 23, 2023 • edited by bedevere-bot
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by bedevere-bot
Uh oh!
There was an error while loading. Please reload this page.
For test_widgets.MenuTest.test_configure_type, the options in the error message change to alphabetical order.
terryjreedy commented May 23, 2023
@chrstphrchvz please verify that this passes on 8.7. @serhiy-storchaka I presume a root.destroy call is needed rather than merely deleting the python binding. If another test in the file ever needs a fix for 8.7 or 9.0, etc., fetching tk_version could be moved to the top of the file, or I could do so now if you prefer. |
terryjreedy commented May 24, 2023
@chrstphrchvz Please verify that this run without error on 8.7. @serhiy-storchaka If tk_ver were someday needed for another test, it could be moved to module level. I can do so now if you want. I presume that explicit root.destroy is needed before exiting the function. |
chrstphrchvz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that the test passes on Tk 8.7 with this change.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
serhiy-storchaka left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use widget.info_patchlevel() in 3.11+, or test.test_tkinter.support.tcl_version or test.test_tkinter.support.get_tk_patchlevel() in older versions.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
terryjreedy commented May 27, 2023
miss-islington commented May 27, 2023
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
bedevere-bot commented May 27, 2023
GH-105028 is a backport of this pull request to the 3.12 branch. |
* pythongh-104497: Make tkinter test pass with tk 8.7 For test_widgets.MenuTest.test_configure_type, the options in the error message change to alphabetical order. * Update Lib/test/test_tkinter/test_widgets.py Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> --------- (cherry picked from commit 897e716) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
bedevere-bot commented May 27, 2023
GH-105029 is a backport of this pull request to the 3.11 branch. |
* pythongh-104497: Make tkinter test pass with tk 8.7 For test_widgets.MenuTest.test_configure_type, the options in the error message change to alphabetical order. * Update Lib/test/test_tkinter/test_widgets.py Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> --------- (cherry picked from commit 897e716) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
For test_widgets.MenuTest.test_configure_type, the options in the error message change to alphabetical order.