Skip to content

Conversation

@msprotz
Copy link
Contributor

@msprotzmsprotz commented May 23, 2023

There have been a few important upstream changes in HACL* that I'd like to bring in, and hopefully backport to the 3.12 branch.

FYI SHA3 is also being integrated into NSS as we speak, hence the active upstream development on making things better.

@msprotz
Copy link
ContributorAuthor

@gpshead let me know if you'd like a NEWS entry or not. Thanks!

@gpsheadgpshead added the needs backport to 3.12 only security fixes label May 24, 2023
@gpshead
Copy link
Member

I'd still add a NEWS entry as it is an observable change and a potential bugfix: Something like Refresh our new HACL* built-in :mod:`hashlib` code from upstream. Built-in SHA2 should be faster and an issue with SHA3 on 32-bit platforms is fixed.

@gpsheadgpshead self-assigned this May 24, 2023
@gpsheadgpshead merged commit 160321e into python:mainMay 24, 2023
@miss-islington
Copy link
Contributor

Thanks @msprotz for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2023
Refresh HACL* from upstream to improve SHA2 performance and fix a 32-bit issue in SHA3. (cherry picked from commit 160321e) Co-authored-by: Jonathan Protzenko <protz@microsoft.com>
@bedevere-bot
Copy link

GH-104893 is a backport of this pull request to the 3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12 only security fixes label May 24, 2023
gpshead pushed a commit that referenced this pull request May 24, 2023
gh-99108: Refresh HACL* (GH-104808) Refresh HACL* from upstream to improve SHA2 performance and fix a 32-bit issue in SHA3. (cherry picked from commit 160321e) Co-authored-by: Jonathan Protzenko <protz@microsoft.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@msprotz@gpshead@miss-islington@bedevere-bot