gh-103295: fix stack overwrite on 32-bit in perf map test harness#104811
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can't use
Kformat specifier inPyArg_ParseTupleto write to avoid *; it always writes 64 bits, so writes too much on 32-bit systems. UseOinstead and an explicit call toPyLong_AsVoidPtrto get the pointer value.Also fix the error check so it detects either error code (
-1or-2) and raises a more informative error usingerrno. I verified this error handling by temporarily changing the perf map file path to a nonexistent directory, and the test raisedFileNotFoundErroras expected.Also simplify the return value to just use
PyLong_FromLong; we don't need to go throughPy_BuildValuefor such a simple case.