Skip to content

Conversation

@barneygale
Copy link
Contributor

@barneygalebarneygale commented May 24, 2023

Merge PurePathTest into _BasePurePathTest, and PathTest into _BasePathTest. No change of coverage.

Merge `PurePathTest` into `_BasePurePathTest`, and `PathTest` into `_BasePathTest`.
@barneygale
Copy link
ContributorAuthor

Note that the _BasePurePathTest and _BasePathTest classes reflect a time long ago when pathlib had pathlib._BasePurePath and pathlib._BasePath classes. These haven't existed since pathlib was an independent package. We may re-introduce them in future (see #104810), but they will look rather different!

@barneygalebarneygale changed the title Clean up pathlib tests.GH-89812: Clean up pathlib tests.Jun 3, 2023
@bedevere-botbedevere-bot mentioned this pull request Jun 3, 2023
@ambv
Copy link
Contributor

ambv commented Jun 13, 2023

This depends on GH-105744.

@barneygalebarneygale requested a review from ambvJune 13, 2023 20:45
@ambv
Copy link
Contributor

ambv commented Jun 14, 2023

I currently don't have a Windows box to test the coverage with, but I tested on macOS and Linux and this looks good to me. Let's go for it! Thanks for the cleanup, Barney! ✨ 🍰 ✨

@ambvambv merged commit dab5a3e into python:mainJun 14, 2023
@ambv
Copy link
Contributor

ambv commented Jun 14, 2023

(If you're curious to check on Windows, the guide is good: https://devguide.python.org/testing/coverage/)

@barneygale
Copy link
ContributorAuthor

Thank you for the review, Łukasz!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip newstestsTests in the Lib/test dirtopic-pathlib

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@barneygale@ambv@bedevere-bot