Skip to content

gh-104873: Add typing.get_protocol_members and typing.is_protocol#104878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JelleZijlstra merged 14 commits into from
Jun 14, 2023
Merged

gh-104873: Add typing.get_protocol_members and typing.is_protocol #104878

JelleZijlstra merged 14 commits into from
Jun 14, 2023

Conversation

@JelleZijlstra
Copy link
Member

@JelleZijlstraJelleZijlstra commented May 24, 2023•
edited by github-actions bot
Loading

@bedevere-botbedevere-bot mentioned this pull request May 24, 2023
Closed
AlexWaygood
AlexWaygood requested changes May 24, 2023
View reviewed changes
@bedevere-bot
Copy link

bedevere-bot commented May 24, 2023

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@JelleZijlstraJelleZijlstra changed the title gh-104873: Add typing.get_protocol_membersgh-104873: Add typing.get_protocol_members and typing.is_protocolMay 24, 2023
@JelleZijlstra
Copy link
MemberAuthor

JelleZijlstra commented May 24, 2023

I didn't expect the Spanish inquisition!

@bedevere-bot
Copy link

bedevere-bot commented May 24, 2023

Nobody expects the Spanish Inquisition!

@AlexWaygood: please review the changes made to this pull request.

AlexWaygood
AlexWaygood reviewed May 24, 2023
View reviewed changes
JelleZijlstraand others added 2 commits May 24, 2023 13:10
@JelleZijlstra@AlexWaygood
Apply suggestions from code review
d1e9dec
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@JelleZijlstra
Merge branch 'main' into protoattrs
4f3e627
AlexWaygood
AlexWaygood reviewed Jun 5, 2023
View reviewed changes
@JelleZijlstra@AlexWaygood
Update Doc/whatsnew/3.13.rst
c91acbb
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
AlexWaygood reviewed Jun 5, 2023
View reviewed changes
AlexWaygood
AlexWaygood reviewed Jun 5, 2023
View reviewed changes
AlexWaygood
AlexWaygood approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd love to get a third opinion from @gvanrossum or @Fidget-Spinner on the API, if possible

@JelleZijlstra
Copy link
MemberAuthor

JelleZijlstra commented Jun 5, 2023

FYI I also just emailed typing-sig about this to ask for feedback.

@JelleZijlstra
Copy link
MemberAuthor

JelleZijlstra commented Jun 13, 2023

Nobody spoke up against this on typing-sig, time to merge?

AlexWaygood
AlexWaygood reviewed Jun 13, 2023
View reviewed changes
AlexWaygood
AlexWaygood reviewed Jun 13, 2023
View reviewed changes
JelleZijlstraand others added 3 commits June 13, 2023 19:37
@JelleZijlstra@AlexWaygood
Apply suggestions from code review
fc4eb5d
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@JelleZijlstra
Merge remote-tracking branch 'upstream/main' into protoattrs
7e8636a
@JelleZijlstra@AlexWaygood
Update Lib/typing.py
8b31c81
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
AlexWaygood approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time to merge, in my opinion!

@JelleZijlstraJelleZijlstra merged commit fc8037d into python:mainJun 14, 2023
@JelleZijlstraJelleZijlstra deleted the protoattrs branch June 14, 2023 12:43
@JelleZijlstraJelleZijlstra restored the protoattrs branch September 10, 2024 23:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

@gvanrossumgvanrossumAwaiting requested review from gvanrossum

@Fidget-SpinnerFidget-SpinnerAwaiting requested review from Fidget-Spinner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JelleZijlstra@bedevere-bot@AlexWaygood