Skip to content

gh-104886: Remove deprecated configparser.LegacyInterpolation#104887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hugovk merged 5 commits into from
May 26, 2023
Merged

gh-104886: Remove deprecated configparser.LegacyInterpolation #104887

hugovk merged 5 commits into from
May 26, 2023

Conversation

@hugovk
Copy link
Member

@hugovkhugovk commented May 24, 2023•
edited by github-actions bot
Loading

Closes#104886.

Remove the undocumented configparser.LegacyInterpolation class.

It was deprecated in the docstring since Python 3.2, deprecated with a warning since Python 3.11, and scheduled for removal in 3.13.

📚 Documentation preview 📚: https://cpython-previews--104887.org.readthedocs.build/

@bedevere-botbedevere-bot mentioned this pull request May 24, 2023
Closed
@hugovkhugovk added stdlib Standard Library Python modules in the Lib/ directory 3.13 bugs and security fixes and removed awaiting core review labels May 24, 2023
@hugovkhugovk mentioned this pull request May 25, 2023
Merged
vstinner
vstinner approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just had a minor suggestion.

@ambv: Was it you who changed this interpolation method?

Wow, it took a while to completely finish the transition :-)

@ambv
Copy link
Contributor

ambv commented May 25, 2023

Yeah, I originally never intended to remove the old one but here we are!

@vstinner
Copy link
Member

vstinner commented May 25, 2023

Yeah, I originally never intended to remove the old one but here we are!

Well, you first wrote:

class BrokenInterpolation(Interpolation): """Deprecated interpolation as implemented in the classic ConfigParser.

It was marked as "deprecated" in the docstring ;-)

Maybe it's time to break the API again, and add a pending deprecated VeryBadlyBrokenInterpolation class :-D

hugovkand others added 2 commits May 25, 2023 19:28
@hugovk@vstinner
Improve wording
823584d
Co-authored-by: Victor Stinner <vstinner@python.org>
@hugovk
Improve wording
039c4f9
vstinner
vstinner approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hugovkhugovk enabled auto-merge (squash) May 26, 2023 05:43
@hugovkhugovk merged commit 3f9c60f into python:mainMay 26, 2023
@hugovkhugovk deleted the rm-configparser.LegacyInterpolation branch May 26, 2023 06:06
@donbarbosdonbarbos mentioned this pull request Aug 10, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

Assignees

No one assigned

Labels

3.13bugs and security fixesstdlibStandard Library Python modules in the Lib/ directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove deprecated configparser.LegacyInterpolation class

4 participants

@hugovk@ambv@vstinner@bedevere-bot