Skip to content

Build docs as part of the MSI test#104929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zooba merged 3 commits into from
May 25, 2023
Merged

Build docs as part of the MSI test #104929

zooba merged 3 commits into from
May 25, 2023

Conversation

@zooba
Copy link
Member

@zoobazooba commented May 25, 2023

No description provided.

@zoobazooba added tests Tests in the Lib/test dir skip issue skip news labels May 25, 2023
@zoobazooba mentioned this pull request May 25, 2023
Merged
@zoobazooba enabled auto-merge (squash) May 25, 2023 11:50
@zoobazooba disabled auto-merge May 25, 2023 12:02
@zoobazooba requested a review from a team as a code ownerMay 25, 2023 12:02
@zoobazooba merged commit 569b2b8 into python:mainMay 25, 2023
@zoobazooba added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels May 25, 2023
@miss-islington
Copy link
Contributor

miss-islington commented May 25, 2023

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented May 25, 2023

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@zoobazooba deleted the msitest branch May 25, 2023 15:17
@miss-islington
Copy link
Contributor

miss-islington commented May 25, 2023

Sorry, @zooba, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 569b2b8d612354062b8679d2d3f44f7ee03e66c2 3.11

@miss-islington
Copy link
Contributor

miss-islington commented May 25, 2023

Sorry @zooba, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 569b2b8d612354062b8679d2d3f44f7ee03e66c2 3.12

@zoobazooba added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels May 25, 2023
@miss-islington
Copy link
Contributor

miss-islington commented May 25, 2023

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2023
@zooba@miss-islington
Improves the Windows MSI test run on PR (pythonGH-104929)
ca15e6a
Correctly set the exit code when builds fail Also build docs as part of the test (cherry picked from commit 569b2b8) Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot
Copy link

bedevere-bot commented May 25, 2023

GH-104934 is a backport of this pull request to the 3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12 only security fixes label May 25, 2023
zooba added a commit that referenced this pull request May 25, 2023
@miss-islington@zooba
Improves the Windows MSI test run on PR (GH-104929)
d176f78
Correctly set the exit code when builds fail Also build docs as part of the test (cherry picked from commit 569b2b8) Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot
Copy link

bedevere-bot commented May 25, 2023

GH-104940 is a backport of this pull request to the 3.10 branch.

zooba added a commit that referenced this pull request May 25, 2023
@zooba
[3.10] Improves the Windows MSI test run on PR (GH-104929)
f22ddbf
Correctly set the exit code when builds fail Also build docs as part of the test
zware
zware reviewed May 25, 2023
View reviewed changes
Copy link
Member

@zwarezware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the fact :)

@erlend-aaslanderlend-aasland mentioned this pull request Jun 6, 2023
Closed
@hugovkhugovk removed the needs backport to 3.11 only security fixes label Feb 20, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zwarezwarezware left review comments

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner

@hugovkhugovkAwaiting requested review from hugovkhugovk is a code owner

Assignees

@zoobazooba

Labels

skip issueskip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zooba@miss-islington@bedevere-bot@zware@hugovk