Skip to content

gh-104935: typing: Fix interactions between @runtime_checkable and Generic#104939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AlexWaygood merged 5 commits into from
May 25, 2023
Merged

gh-104935: typing: Fix interactions between @runtime_checkable and Generic #104939

AlexWaygood merged 5 commits into from
May 25, 2023

Conversation

@JelleZijlstra
Copy link
Member

@JelleZijlstraJelleZijlstra commented May 25, 2023•
edited by bedevere-bot
Loading

@bedevere-botbedevere-bot mentioned this pull request May 25, 2023
Closed
AlexWaygood
AlexWaygood reviewed May 25, 2023
View reviewed changes
AlexWaygood
AlexWaygood reviewed May 25, 2023
View reviewed changes
JelleZijlstraand others added 3 commits May 25, 2023 09:12
@JelleZijlstra@AlexWaygood
Update Lib/test/test_typing.py
19bbcb0
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@JelleZijlstra
Better approach
f299fbd
@JelleZijlstra
Update news
0859dcd
@JelleZijlstraJelleZijlstra changed the title gh-104935: Add back typing.Generic._is_protocolgh-104935: typing: Fix interactions between @runtime_checkable and GenericMay 25, 2023
@AlexWaygoodAlexWaygood removed the request for review from markshannonMay 25, 2023 16:22
AlexWaygood
AlexWaygood approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@AlexWaygoodAlexWaygood enabled auto-merge (squash) May 25, 2023 16:23
@AlexWaygoodAlexWaygood merged commit 2b7027d into python:mainMay 25, 2023
@miss-islington
Copy link
Contributor

miss-islington commented May 25, 2023

Thanks @JelleZijlstra for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented May 25, 2023

Sorry @JelleZijlstra and @AlexWaygood, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 2b7027d0b2ee2e102a24a0da27d01b8221f9351c 3.12

@AlexWaygoodAlexWaygood added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels May 25, 2023
@miss-islington
Copy link
Contributor

miss-islington commented May 25, 2023

Thanks @JelleZijlstra for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@JelleZijlstraJelleZijlstra removed the needs backport to 3.12 only security fixes label May 25, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2023
@JelleZijlstra@AlexWaygood@miss-islington
pythongh-104935: typing: Fix interactions between `@runtime_checkable…
f67a992
…` and `Generic` (pythonGH-104939) --------- (cherry picked from commit 2b7027d) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented May 25, 2023

GH-104941 is a backport of this pull request to the 3.12 branch.

@JelleZijlstraJelleZijlstra added the needs backport to 3.12 only security fixes label May 25, 2023
@miss-islington
Copy link
Contributor

miss-islington commented May 25, 2023

Thanks @JelleZijlstra for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@JelleZijlstraJelleZijlstra deleted the is_protocol branch May 25, 2023 16:44
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2023
@JelleZijlstra@AlexWaygood@miss-islington
pythongh-104935: typing: Fix interactions between `@runtime_checkable…
70cc4e5
…` and `Generic` (pythonGH-104939) --------- (cherry picked from commit 2b7027d) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@JelleZijlstra
Copy link
MemberAuthor

JelleZijlstra commented May 25, 2023

oops

@AlexWaygood
Copy link
Member

AlexWaygood commented May 25, 2023

Yeah you made @miss-islington force-push to her PR branch!

AlexWaygood added a commit that referenced this pull request May 25, 2023
@miss-islington@JelleZijlstra@AlexWaygood
[3.12]gh-104935: typing: Fix interactions between `@runtime_checkabl…
930efde
…e` and `Generic` (GH-104939) (#104941) gh-104935: typing: Fix interactions between `@runtime_checkable` and `Generic` (GH-104939) --------- (cherry picked from commit 2b7027d) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@erlend-aaslanderlend-aasland mentioned this pull request Jun 6, 2023
Closed
@JelleZijlstraJelleZijlstra restored the is_protocol branch September 10, 2024 23:37
@ZeroIntensityZeroIntensity removed the needs backport to 3.12 only security fixes label Feb 17, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

@gvanrossumgvanrossumAwaiting requested review from gvanrossum

@Fidget-SpinnerFidget-SpinnerAwaiting requested review from Fidget-Spinner

Assignees

@AlexWaygoodAlexWaygood

Labels

topic-typing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JelleZijlstra@miss-islington@bedevere-bot@AlexWaygood@ZeroIntensity