Skip to content

gh-104839: Prevent test_venv AddressSanitizer spam#105005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gpshead merged 1 commit into from
May 27, 2023
Merged

gh-104839: Prevent test_venv AddressSanitizer spam #105005

gpshead merged 1 commit into from
May 27, 2023

Conversation

@gpshead
Copy link
Member

@gpsheadgpshead commented May 26, 2023•
edited
Loading

Pass any ASAN_OPTIONS environment variable through to the child process so that leak sanitizer being disabled on our CI and buildbots stays true in the children.

Fixes#104839.

@gpshead
pythongh-104839: Prevent test_venv AddressSanitizer spam
29389b8
Pass any ASAN_OPTIONS environment variable through to the child process so that leak sanitizer being disabled on our CI and buildbots stays true in the children.
@gpsheadgpshead added tests Tests in the Lib/test dir skip news needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels May 26, 2023
@gpsheadgpshead requested a review from vsajip as a code ownerMay 26, 2023 23:43
@bedevere-botbedevere-bot mentioned this pull request May 26, 2023
Closed
@gpshead
Copy link
MemberAuthor

gpshead commented May 27, 2023

Only 596 lines of output in the Address Sanitizer Tests CI run. Yay, normal. No longer 50,000 and 5MiB.

@gpsheadgpshead merged commit a17f160 into python:mainMay 27, 2023
@miss-islington
Copy link
Contributor

miss-islington commented May 27, 2023

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@gpsheadgpshead deleted the test_venv_asan branch May 27, 2023 01:15
@miss-islington
Copy link
Contributor

miss-islington commented May 27, 2023

Sorry, @gpshead, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a17f160376955d369c8d332e1b1a90a6e18c852a 3.11

@miss-islington
Copy link
Contributor

miss-islington commented May 27, 2023

Sorry @gpshead, I had trouble checking out the 3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker a17f160376955d369c8d332e1b1a90a6e18c852a 3.10

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 27, 2023
@gpshead@miss-islington
pythongh-104839: Prevent test_venv AddressSanitizer spam (pythonGH-10…
0e38b6c
…5005) Pass any ASAN_OPTIONS environment variable through to the child process so that leak sanitizer being disabled on our CI and buildbots stays true in the children. (cherry picked from commit a17f160) Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-bot
Copy link

bedevere-bot commented May 27, 2023

GH-105006 is a backport of this pull request to the 3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12 only security fixes label May 27, 2023
@gpsheadgpshead removed needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels May 27, 2023
gpshead added a commit that referenced this pull request May 27, 2023
@miss-islington@gpshead
[3.12]gh-104839: Prevent test_venv AddressSanitizer spam (GH-105005) (…
f625ec3
…#105006) gh-104839: Prevent test_venv AddressSanitizer spam (GH-105005) Pass any ASAN_OPTIONS environment variable through to the child process so that leak sanitizer being disabled on our CI and buildbots stays true in the children. (cherry picked from commit a17f160) Co-authored-by: Gregory P. Smith [Google] <greg@krypto.org>
@erlend-aaslanderlend-aasland mentioned this pull request Jun 6, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajipvsajipAwaiting requested review from vsajipvsajip is a code owner

Assignees

@gpsheadgpshead

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test_venv spams our AddressSanitizer CI with 5mb of test logs

3 participants

@gpshead@miss-islington@bedevere-bot