CI: Precompute hash for config cache key in check_source job#105008
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
hugovk added needs backport to 3.11 
Contributor
miss-islington commented May 27, 2023
Contributor
miss-islington commented May 27, 2023
Contributor
miss-islington commented May 27, 2023
Sorry, @itamaro and @hugovk, I could not cleanly backport this to |
Contributor
miss-islington commented May 27, 2023
Sorry @itamaro and @hugovk, I had trouble checking out the |
Member
@itamaro Please could you backport these to |
hugovk added needs backport to 3.12 Contributor
miss-islington commented May 27, 2023
bedevere-bot commented May 27, 2023
GH-105014 is a backport of this pull request to the 3.12 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 27, 2023
bedevere-bot commented May 27, 2023
GH-105024 is a backport of this pull request to the 3.11 branch. |
itamaro added a commit to itamaro/cpython that referenced this pull request May 27, 2023
…ythonGH-105008) Backport of pythongh-105014 to 3.11 (manually cherry picked from commit 949f0f5)
hugovk pushed a commit that referenced this pull request May 27, 2023
Contributor
erlend-aasland commented May 29, 2023
Nice; thanks! |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to gh-104800, since all the build jobs already depend on the check_source job, we can precompute the hash in that job and reuse it in the downstream jobs.
While the time saving is negligible, the main benefit of this change is that the list of hashed files is not repeated in multiple places.