Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 33.9k
gh-105017: Include CRLF lines in strings and column numbers#105030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
Uh oh!
There was an error while loading. Please reload this page.
pablogsal commented May 27, 2023
There were a bunch of failing tests because we are removing CRLF handling in the regular path that expects the source to be normalized. I pushed a commit that only preserves CRLF in our tokenize extension |
Uh oh!
There was an error while loading. Please reload this page.
bedevere-bot commented May 28, 2023
🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 363de28 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
bedevere-bot commented May 28, 2023
🤖 New build scheduled with the buildbot fleet by @pablogsal for commit d3d4ff5 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
miss-islington commented May 28, 2023
Thanks @mgmacias95 for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
…thonGH-105030) (cherry picked from commit 96fff35) Co-authored-by: Marta Gómez Macías <mgmacias@google.com> Co-authored-by: Pablo Galindo <pablogsal@gmail.com>
bedevere-bot commented May 28, 2023
GH-105041 is a backport of this pull request to the 3.12 branch. |
pablogsal left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Great job! ✨
bedevere-bot commented May 28, 2023
|
Uh oh!
There was an error while loading. Please reload this page.