Skip to content

Conversation

@Jackenmen
Copy link
Contributor

@JackenmenJackenmen commented May 28, 2023

It seems that end_lineno, and end_offset have been missed when the SyntaxError exception was modified in 3.10.

I reused the issue number of the original issue that added these attributes.


📚 Documentation preview 📚: https://cpython-previews--105046.org.readthedocs.build/

@iritkatrieliritkatriel requested a review from akulakovMay 28, 2023 21:25
@iritkatrieliritkatriel added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes docs Documentation in the Doc dir labels May 28, 2023
@iritkatrieliritkatriel changed the title gh-89412: Add missing 3.10 attributes to traceback module docsgh-89412: Add missing attributes (added in 3.10) to traceback module docsMay 29, 2023
@akulakov
Copy link
Contributor

@pablogsal can you review as you've added these two attributes in #28575 ?

@ambvambv merged commit a4f72fa into python:mainJun 5, 2023
@miss-islington
Copy link
Contributor

Thanks @Jackenmen for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11, 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-105327 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 5, 2023
…odule docs (pythonGH-105046) (cherry picked from commit a4f72fa) Co-authored-by: Jakub Kuczys <me@jacken.men>
@bedevere-botbedevere-bot removed the needs backport to 3.12 only security fixes label Jun 5, 2023
@bedevere-bot
Copy link

GH-105328 is a backport of this pull request to the 3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Jun 5, 2023
@bedevere-bot
Copy link

GH-105329 is a backport of this pull request to the 3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label Jun 5, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 5, 2023
…odule docs (pythonGH-105046) (cherry picked from commit a4f72fa) Co-authored-by: Jakub Kuczys <me@jacken.men>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 5, 2023
…odule docs (pythonGH-105046) (cherry picked from commit a4f72fa) Co-authored-by: Jakub Kuczys <me@jacken.men>
ambv pushed a commit that referenced this pull request Jun 5, 2023
…module docs (GH-105046) (#105327) (cherry picked from commit a4f72fa) Co-authored-by: Jakub Kuczys <me@jacken.men>
ambv pushed a commit that referenced this pull request Jun 5, 2023
…module docs (GH-105046) (#105328) (cherry picked from commit a4f72fa) Co-authored-by: Jakub Kuczys <me@jacken.men>
ambv pushed a commit that referenced this pull request Jun 5, 2023
…module docs (GH-105046) (#105329) (cherry picked from commit a4f72fa) Co-authored-by: Jakub Kuczys <me@jacken.men>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x SLES 3.11 has failed when building commit faae548.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1006/builds/1010) and take a look at the build logs.
  4. Check if the failure is related to this commit (faae548) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1006/builds/1010

Failed tests:

  • test___all__

Failed subtests:

  • test_all - test.test___all__.AllTest.test_all

Summary of the results of the build (if available):

== Tests result: FAILURE then ENV CHANGED ==

419 tests OK.

10 slowest tests:

  • test_tools: 2 min 57 sec
  • test_concurrent_futures: 2 min 25 sec
  • test_multiprocessing_spawn: 2 min 3 sec
  • test_multiprocessing_fork: 1 min 30 sec
  • test_multiprocessing_forkserver: 1 min 15 sec
  • test_asyncio: 1 min 13 sec
  • test_tokenize: 51.2 sec
  • test_signal: 48.0 sec
  • test_capi: 41.4 sec
  • test_unparse: 40.1 sec

1 test altered the execution environment:
test_asyncio

14 tests skipped:
test_devpoll test_ioctl test_kqueue test_launcher test_msilib
test_nis test_startfile test_tix test_tk test_ttk_guionly
test_winconsoleio test_winreg test_winsound test_zipfile64

1 re-run test:
test___all__

Total duration: 5 min 22 sec

Click to see traceback logs
Traceback (most recent call last): File "/home/dje/cpython-buildarea/3.11.edelsohn-sles-z/build/Lib/multiprocessing/resource_tracker.py", line 209, in main cache[rtype].remove(name) KeyError: '/psm_689e16ea' Traceback (most recent call last): File "/home/dje/cpython-buildarea/3.11.edelsohn-sles-z/build/Lib/test/test___all__.py", line 129, in test_allself.check_all(modname) File "/home/dje/cpython-buildarea/3.11.edelsohn-sles-z/build/Lib/test/test___all__.py", line 43, in check_allwith warnings_helper.check_warnings( File "/home/dje/cpython-buildarea/3.11.edelsohn-sles-z/build/Lib/contextlib.py", line 144, in __exit__next(self.gen) File "/home/dje/cpython-buildarea/3.11.edelsohn-sles-z/build/Lib/test/support/warnings_helper.py", line 185, in _filterwarningsraiseAssertionError("unhandled warning %s"% reraise[0]) AssertionError: unhandled warning{message : DeprecationWarning("invalid escape sequence '\\?'"), category : 'DeprecationWarning', filename : '/home/dje/cpython-buildarea/3.11.edelsohn-sles-z/build/Lib/test/test_httpservers.py', lineno : 445, line : None} Traceback (most recent call last): File "/home/dje/cpython-buildarea/3.11.edelsohn-sles-z/build/Lib/multiprocessing/resource_tracker.py", line 209, in main cache[rtype].remove(name) KeyError: '/psm_07ea7738' Traceback (most recent call last): File "/home/dje/cpython-buildarea/3.11.edelsohn-sles-z/build/Lib/multiprocessing/resource_tracker.py", line 209, in main cache[rtype].remove(name) KeyError: '/psm_2bd8fa86'

@JackenmenJackenmen deleted the traceback-docs-3.10-changes branch June 5, 2023 18:27
@gpshead
Copy link
Member

thanks for doing this!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation in the Doc dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@Jackenmen@akulakov@miss-islington@bedevere-bot@gpshead@ambv@iritkatriel