Skip to content

gh-105042: Disable unmatched parens syntax error in python tokenize#105061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pablogsal merged 3 commits into from
May 30, 2023
Merged

gh-105042: Disable unmatched parens syntax error in python tokenize #105061

pablogsal merged 3 commits into from
May 30, 2023

Conversation

@lysnikolaou
Copy link
Member

@lysnikolaoulysnikolaou commented May 29, 2023•
edited by bedevere-bot
Loading

@bedevere-botbedevere-bot mentioned this pull request May 29, 2023
Closed
pablogsal
pablogsal reviewed May 30, 2023
View reviewed changes
@pablogsal
Copy link
Member

pablogsal commented May 30, 2023

We also need a bunch of tests that cover these, one in the inspect module and the other in the tokenize module

pablogsal
pablogsal reviewed May 30, 2023
View reviewed changes
pablogsal
pablogsal reviewed May 30, 2023
View reviewed changes
@lysnikolaoulysnikolaouforce-pushed the tokenize-unmatched-parens branch from 049da25 to ed1237aCompareMay 30, 2023 09:55
@lysnikolaoulysnikolaou marked this pull request as ready for review May 30, 2023 09:56
@lysnikolaou
Copy link
MemberAuthor

lysnikolaou commented May 30, 2023

@pablogsal This is ready for another review.

@pablogsal
Copy link
Member

pablogsal commented May 30, 2023•
edited
Loading

We also need a bunch of tests that cover these, one in the inspect module and the other in the tokenize module

Can you add a couple of tests for this?

Maybe something on these lines: #105042 (comment) in the inspect module here:

cpython/Lib/test/test_inspect.py

Line 779 in 0656d23

deftest_parenthesized_multiline_lambda(self):

@lysnikolaou
Copy link
MemberAuthor

lysnikolaou commented May 30, 2023

@pablogsal Thanks for the reminder! Tests added in c7481a5.

pablogsal
pablogsal approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@pablogsalpablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Fantastic work!

@pablogsalpablogsal added the needs backport to 3.12 only security fixes label May 30, 2023
@pablogsalpablogsal merged commit 70f315c into python:mainMay 30, 2023
@miss-islington
Copy link
Contributor

miss-islington commented May 30, 2023

Thanks @lysnikolaou for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 30, 2023
@lysnikolaou@miss-islington
pythongh-105042: Disable unmatched parens syntax error in python toke…
bb899c1
…nize (pythonGH-105061) (cherry picked from commit 70f315c) Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented May 30, 2023

GH-105120 is a backport of this pull request to the 3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12 only security fixes label May 30, 2023
pablogsal pushed a commit that referenced this pull request May 31, 2023
@miss-islington@lysnikolaou
[3.12]gh-105042: Disable unmatched parens syntax error in python tok…
2f8c22f
…enize (GH-105061) (#105120) gh-105042: Disable unmatched parens syntax error in python tokenize (GH-105061) (cherry picked from commit 70f315c) Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
@erlend-aaslanderlend-aasland mentioned this pull request Jun 6, 2023
Closed
@asottileasottile mentioned this pull request Jun 13, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsalpablogsalpablogsal approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lysnikolaou@pablogsal@miss-islington@bedevere-bot