Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 33.9k
gh-89886: Properly quote Autoconf macro arguments#105062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-89886: Properly quote Autoconf macro arguments #105062
Uh oh!
There was an error while loading. Please reload this page.
Conversation
erlend-aasland commented May 29, 2023 • edited by bedevere-bot
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by bedevere-bot
Uh oh!
There was an error while loading. Please reload this page.
Autoconf 2.70 macros are picky about argument quotation.
bedevere-bot commented May 29, 2023
🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 80794c7 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Uh oh!
There was an error while loading. Please reload this page.
erlend-aasland commented May 29, 2023
On hold until |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
erlend-aasland commented May 30, 2023
Thanks for the reviews, y'all! |
erlend-aasland commented May 30, 2023
Here's some fun reading for you: https://www.gnu.org/software/autoconf/manual/autoconf-2.71/html_node/Coding-Style.html |
gpshead left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for taking this on.
miss-islington commented May 30, 2023
Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington commented May 30, 2023
Sorry, @erlend-aasland, I could not cleanly backport this to |
bedevere-bot commented May 30, 2023
GH-105118 is a backport of this pull request to the 3.12 branch. |
…n#105062) Autoconf 2.70 macros are picky about argument quotation.
bedevere-bot commented May 31, 2023
|
Autoconf 2.70 macros are picky about argument quotation.