gh-105077: Fix test_tkinter refleak checking#105078
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Use specific symbols from `test.support` to avoid having `support` overwritten by `test_tkinter`'s own `support` submodule.
zware added type-bug 
JelleZijlstra approved these changes May 30, 2023
Contributor
miss-islington commented May 30, 2023
Thanks @zware for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 30, 2023
Use specific symbols from `test.support` to avoid having `support` overwritten by `test_tkinter`'s own `support` submodule. (cherry picked from commit 5454db4) Co-authored-by: Zachary Ware <zach@python.org>
bedevere-bot commented May 30, 2023
GH-105079 is a backport of this pull request to the 3.12 branch. |
zware pushed a commit that referenced this pull request May 30, 2023
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use specific symbols from
test.supportto avoid havingsupportoverwritten by
test_tkinter's ownsupportsubmodule.test_tkinterfails on refleak run due tosupportconfusion #105077