gh-105020: Share tp_bases and tp_mro Between Interpreters For All Static Builtin Types#105115
Uh oh!
There was an error while loading. Please reload this page.
Conversation
gpshead left a comment
gpshead left a comment There was a problem hiding this comment.
Do we have a meaningful place to put a regression test to assert that tp_bases and tp_mro are never NULL in the situations user code was encountering that in 3.12beta1?
Include/internal/pycore_typeobject.h Outdated
| PyTypeObject*type; | ||
| intreadying; | ||
| intready; | ||
| // XXX tp_dict, tp_bases, and tp_mro can probably be statically |
There was a problem hiding this comment.
should this comment (added by the original PR) be updated now that bases and mro don't exist here?
ericsnowcurrently commented May 30, 2023
I'll add a test in |
ericsnowcurrently commented May 30, 2023
I've added a test. Thanks for the suggestion. |
gpshead left a comment
gpshead left a comment There was a problem hiding this comment.
This looks good to me.
I do wonder if anything is going to be tripped up by the tp_dict as well, but that seems like a separate category of change given I believe it could've been NULL in the past - if it comes up it can be addressed separately.
gpshead commented May 30, 2023
you might want a NEWS entry fwiw... as people do read the changelog between beta1 and beta2. |
miss-islington commented May 31, 2023
Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington commented May 31, 2023
Sorry @ericsnowcurrently, I had trouble checking out the |
ericsnowcurrently added needs backport to 3.12 miss-islington commented May 31, 2023
Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
…ll Static Builtin Types (pythongh-105115) In pythongh-103912 we added tp_bases and tp_mro to each PyInterpreterState.types.builtins entry. However, doing so ignored the fact that both PyTypeObject fields are public API, and not documented as internal (as opposed to tp_subclasses). We address that here by reverting back to shared objects, making them immortal in the process. (cherry picked from commit 7be667d) Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
bedevere-bot commented May 31, 2023
GH-105124 is a backport of this pull request to the 3.12 branch. |
…All Static Builtin Types (gh-105115) (gh-105124) In gh-103912 we added tp_bases and tp_mro to each PyInterpreterState.types.builtins entry. However, doing so ignored the fact that both PyTypeObject fields are public API, and not documented as internal (as opposed to tp_subclasses). We address that here by reverting back to shared objects, making them immortal in the process. (cherry picked from commit 7be667d) Co-authored-by: Eric Snow ericsnowcurrently@gmail.com
4 participants
In gh-103912 we added tp_bases and tp_mro to each
PyInterpreterState.types.builtinsentry. However, doing so ignored the fact that bothPyTypeObjectfields are public API, and not documented as internal (as opposed to tp_subclasses). We address that here by reverting back to shared objects, making them immortal in the process.tp_basesofobjectisNULL: undocumented or unintentional behavior change in 3.12? #105020