Skip to content

Conversation

@ned-deily
Copy link
Member

@ned-deilyned-deily commented May 31, 2023

@ned-deilyned-deily added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels May 31, 2023
@ned-deilyned-deily changed the title Update multissltest helper to test with OpenSSL 1.1.1u, 3.0.9, and 3.1.1.gh-103142: Update multissltest helper to test with OpenSSL 1.1.1u, 3.0.9, and 3.1.1.May 31, 2023
@ned-deilyned-deily changed the title gh-103142: Update multissltest helper to test with OpenSSL 1.1.1u, 3.0.9, and 3.1.1.gh-103142: Update error codes, multissltests, and CI workflows for OpenSSL 1.1.1u, 3.0.9, and 3.1.1.May 31, 2023
@ned-deilyned-deily requested review from ambv and gpsheadMay 31, 2023 19:48
@gpshead
Copy link
Member

There are PCbuild/ and .azure-pipelines/ references that also need updating (see my draft #105174 which I was just basing off of what I blindly did for the previous update in #101727). But lets go forward with your PR here just adding those bits. I don't think I ever looked at that make_ssl_data.py generated .h file of string/constant definitions.

@gpshead
Copy link
Member

some windows versions may need to wait on someone uploading an openssl-bin-1.1.1u artifact somewhere? based on #101727 comments @zooba did that last time.

@gpsheadgpshead requested a review from zoobaMay 31, 2023 22:22
@zooba
Copy link
Member

I've posted the binaries for Windows. They are codesigned, so have to be done by someone with release team access.

I don't think I ever looked at that make_ssl_data.py generated .h file of string/constant definitions.

I thought there was an open issue/PR to replace this file? As we should have access to OpenSSL's copies of this data. Guess it isn't merged yet...

@gpshead
Copy link
Member

I updated my PR #105174 to have the additional bits that this touched plus a tweak to the _ssl_data .h file regeneration. If CI and buildbots are happy with it, I'll merge mine and generate the backport PRs.

@gpsheadgpshead marked this pull request as draft June 1, 2023 03:32
@ned-deily
Copy link
MemberAuthor

Closed in favor of #105174

@gpshead
Copy link
Member

woo, thanks Ned! (we were both considering this, when I created my PR I hadn't yet looked to see if someone else had taken this on. No worries from my end about the duplicate work collision, it's good to have eyeballs on the issue).

@ned-deilyned-deily deleted the gh-103142-multissltests branch June 6, 2023 18:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

5 participants

@ned-deily@gpshead@zooba@ambv@bedevere-bot