Skip to content

gh-92536: Remove PyUnicode_READY() calls#105210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 2 commits into from
Jun 1, 2023
Merged

gh-92536: Remove PyUnicode_READY() calls #105210

vstinner merged 2 commits into from
Jun 1, 2023

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commented Jun 1, 2023•
edited by bedevere-bot
Loading

Since Python 3.12, PyUnicode_READY() does nothing and always returns 0.

@vstinner
pythongh-92536: Remove PyUnicode_READY() calls
63ba3dc
Since Python 3.12, PyUnicode_READY() does nothing and always returns 0.
@bedevere-botbedevere-bot mentioned this pull request Jun 1, 2023
Closed
@vstinnervstinner mentioned this pull request Jun 1, 2023
Merged
@vstinner
Copy link
MemberAuthor

vstinner commented Jun 1, 2023

See also PR #105208.

@vstinnervstinner merged commit ef30093 into python:mainJun 1, 2023
@vstinnervstinner deleted the remove_pyunicode_ready branch June 1, 2023 23:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10corona10Awaiting requested review from corona10corona10 is a code owner

@rhettingerrhettingerAwaiting requested review from rhettinger

@pablogsalpablogsalAwaiting requested review from pablogsalpablogsal is a code owner

@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner

@pgansslepganssleAwaiting requested review from pgansslepganssle is a code owner

@abalkinabalkinAwaiting requested review from abalkinabalkin is a code owner

@brettcannonbrettcannonAwaiting requested review from brettcannonbrettcannon is a code owner

@encukouencukouAwaiting requested review from encukou

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner

@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

@iritkatrieliritkatrielAwaiting requested review from iritkatrieliritkatriel is a code owner

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner@bedevere-bot