gh-105080: Fixed inconsistent signature on derived classes#105217
Merged
+31 −11
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the code above,
inspect.signature(D2)will give a different result thaninspect.signature(D1), which is counter-intuitive. This also affectshelp(D2)vshelp(D1).We should keep the consistency for the signatures for derived classes (of course when the signature is not changed).
This is due to a corner case in
inspect.signature()where only the direct defined__init__and__new__method on the class takes priority, then__new__is always used if defined on any base classes. This fix searches__new__and__init__based on MRO and prioritize__new__if both are defined on a base class.