gh-104310: Rename the New Function in importlib.util#105255
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ericsnowcurrently requested review from brettcannon, encukou, ncoghlan and warsaw as code owners
MemberAuthor
ericsnowcurrently commented Jun 2, 2023
CC @brettcannon |
ericsnowcurrently changed the title Uh oh!
There was an error while loading. Please reload this page.
Eclips4 reviewed Jun 2, 2023
Misc/NEWS.d/next/Library/2023-06-02-14-23-41.gh-issue-104310.UamCOB.rst Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
…amCOB.rst Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
brettcannon requested changes Jun 8, 2023
Lib/importlib/util.py Outdated
| def__init__(self, disable_check=True): | ||
| self.disable_check=disable_check | ||
| def__init__(self, disable_check): |
Member
There was a problem hiding this comment.
Without the keyword, _incompatible_extension_module_restrictions(True) reads to me like incompatible module restrictions are turned on. I would either make the parameter keyword-only or invert the meaning (i.e., enable_check).
bedevere-bot commented Jun 8, 2023
When you're done making the requested changes, leave the comment: |
brettcannon approved these changes Jun 8, 2023
Contributor
miss-islington commented Jun 8, 2023
Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2023
…105255) The original name wasn't as clear as it could have been. This change includes the following: * rename the function * change the default value for "disable_check" to False * add clues to the docstring that folks should probably not use the function --------- (cherry picked from commit 34c63b8) Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com> Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
bedevere-bot commented Jun 8, 2023
GH-105518 is a backport of this pull request to the 3.12 branch. |
ericsnowcurrently added a commit that referenced this pull request Jun 8, 2023
… (gh-105518) The original name wasn't as clear as it could have been. This change includes the following: * rename the function * change the default value for "disable_check" to False * add clues to the docstring that folks should probably not use the function --------- (cherry picked from commit 34c63b8) Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com> Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original name wasn't as clear as it could have been. This change includes the following:
False