Skip to content

Conversation

@miss-islington
Copy link
Contributor

@miss-islingtonmiss-islington commented Jun 6, 2023

  • Add "limited-c-api" and "stable-api" references.

  • Rename "stable-abi-list" reference to "limited-api-list".

  • Makefile: Document files regenerated by "make regen-limited-abi"

  • Remove first empty line in generated files:

    • Lib/test/test_stable_abi_ctypes.py
    • PC/python3dll.c
      (cherry picked from commit bae415a)

Co-authored-by: Victor Stinner vstinner@python.org


📚 Documentation preview 📚: https://cpython-previews--105347.org.readthedocs.build/

…onGH-105345) * Add "limited-c-api" and "stable-api" references. * Rename "stable-abi-list" reference to "limited-api-list". * Makefile: Document files regenerated by "make regen-limited-abi" * Remove first empty line in generated files: - Lib/test/test_stable_abi_ctypes.py - PC/python3dll.c (cherry picked from commit bae415a) Co-authored-by: Victor Stinner <vstinner@python.org>
Copy link
Member

@encukouencukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still reviewing, see the PR for main: #105345

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@vstinner
Copy link
Member

I'm still reviewing, see the PR for main: #105345

I prefer to address review in a separated PR (that I will also backport to Python 3.12).

This change is now blocking the Py_INCREF fix backport to Python 3.12: PR #105352.

@vstinner
Copy link
Member

I wrote PR #105371 instead.

@vstinnervstinner closed this Jun 6, 2023
auto-merge was automatically disabled June 6, 2023 12:41

Pull request was closed

@miss-islingtonmiss-islington deleted the backport-bae415a-3.12 branch June 6, 2023 12:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@miss-islington@bedevere-bot@vstinner@encukou