Skip to content

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commented Jun 9, 2023

Add proper error handling to prevent reference leaks and overwritten
exceptions.

Add proper error handling to prevent reference leaks and overwritten exceptions.
Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several problems fixed! Great! 👍

@erlend-aaslanderlend-aasland merged commit 01f4230 into python:mainJun 11, 2023
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@erlend-aaslanderlend-aasland deleted the improve-ssl-error-handling branch June 11, 2023 09:56
@miss-islington
Copy link
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 01f4230460454d4a849a5ba93320142c1a0c93a8 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 11, 2023
Add proper error handling to prevent reference leaks and overwritten exceptions. (cherry picked from commit 01f4230) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot
Copy link

GH-105642 is a backport of this pull request to the 3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12 only security fixes label Jun 11, 2023
erlend-aasland added a commit that referenced this pull request Jun 11, 2023
Add proper error handling to prevent reference leaks and overwritten exceptions. (cherry picked from commit 01f4230) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jun 11, 2023
(cherry picked from commit 01f4230) Add proper error handling to prevent reference leaks and overwritten exceptions. Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot
Copy link

GH-105651 is a backport of this pull request to the 3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Jun 11, 2023
erlend-aasland added a commit that referenced this pull request Jun 11, 2023
(cherry picked from commit 01f4230) Add proper error handling to prevent reference leaks and overwritten exceptions. Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland@miss-islington@bedevere-bot@sobolevn