Skip to content

gh-105375: Improve error handling in the sys extension module#105611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
erlend-aasland merged 2 commits into from
Jun 11, 2023
Merged

gh-105375: Improve error handling in the sys extension module #105611

erlend-aasland merged 2 commits into from
Jun 11, 2023

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commented Jun 9, 2023•
edited by bedevere-bot
Loading

Bail on first error to prevent exceptions from possibly being
overwritten.

@erlend-aasland
pythongh-105375: Improve error handling in the sys extension module
02cac21
Bail on first error to prevent exceptions from possibly being overwritten.
@erlend-aaslanderlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jun 9, 2023
@bedevere-botbedevere-bot mentioned this pull request Jun 9, 2023
Closed
18 tasks
@erlend-aaslanderlend-aasland added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jun 11, 2023
@bedevere-bot
Copy link

bedevere-bot commented Jun 11, 2023

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 02cac21 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jun 11, 2023
@erlend-aaslanderlend-aasland enabled auto-merge (squash) June 11, 2023 19:38
@erlend-aaslanderlend-aasland enabled auto-merge (squash) June 11, 2023 19:39
@erlend-aaslanderlend-aasland merged commit 41cddc2 into python:mainJun 11, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Jun 11, 2023

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jun 11, 2023

Sorry, @erlend-aasland, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 41cddc2e93a285b81fa30ac542b088bd9d0112e9 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 11, 2023
@erlend-aasland@miss-islington
pythongh-105375: Improve error handling in the sys extension module (p…
753d979
…ythonGH-105611) In _PySys_AddXOptionWithError() and sys_add_xoption(), bail on first error to prevent exceptions from possibly being overwritten. (cherry picked from commit 41cddc2) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Jun 11, 2023

GH-105665 is a backport of this pull request to the 3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12 only security fixes label Jun 11, 2023
@erlend-aaslanderlend-aasland deleted the improve-sysmodule-error-handling branch June 11, 2023 20:05
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jun 11, 2023
@erlend-aasland
[3.11]pythongh-105375: Improve error handling in the sys extension m…
3d5eb67
…odule (python#105611) (cherry picked from commit 41cddc2) In _PySys_AddXOptionWithError() and sys_add_xoption(), bail on first error to prevent exceptions from possibly being overwritten. Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Jun 11, 2023

GH-105666 is a backport of this pull request to the 3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Jun 11, 2023
erlend-aasland added a commit that referenced this pull request Jun 11, 2023
@erlend-aasland
[3.11]gh-105375: Improve error handling in the sys extension module (#…
f98d475
…105611) (#105666) (cherry picked from commit 41cddc2) In _PySys_AddXOptionWithError() and sys_add_xoption(), bail on first error to prevent exceptions from possibly being overwritten.
erlend-aasland added a commit that referenced this pull request Jun 11, 2023
@miss-islington@erlend-aasland
[3.12]gh-105375: Improve error handling in the sys extension module (G…
a1034b5
…H-105611) (#105665) In _PySys_AddXOptionWithError() and sys_add_xoption(), bail on first error to prevent exceptions from possibly being overwritten. (cherry picked from commit 41cddc2) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
serhiy-storchaka
serhiy-storchaka reviewed Jun 12, 2023
View reviewed changes
@sobolevnsobolevn mentioned this pull request Jun 12, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka left review comments

@sobolevnsobolevnAwaiting requested review from sobolevn

Assignees

@erlend-aaslanderlend-aasland

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@erlend-aasland@bedevere-bot@miss-islington@serhiy-storchaka@sobolevn