gh-105375: Explicitly initialise all{Pickler,Unpickler}Object fields#105686
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…fields PyObject_GC_New() only initialises the object header. All other fields must be explicitly initialised to prevent manipulation of uninitialised fields in dealloc. Align initialisation order with the layout of the object structs.
erlend-aasland added skip news needs backport to 3.11 
18 tasks
- Prepare memory allocations and new objects before calling PyObject_GC_New() - Initialise all fields at once using a series of assignments only - Use error labels for clarity
Member
serhiy-storchaka left a comment
serhiy-storchaka left a comment There was a problem hiding this comment.
I think that it is enough to set output_buffer = NULL.
ContributorAuthor
erlend-aasland commented Jun 12, 2023
You also need to adjust |
serhiy-storchaka approved these changes Jun 12, 2023
Contributor
miss-islington commented Jun 12, 2023
Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
Contributor
miss-islington commented Jun 12, 2023
Sorry, @erlend-aasland, I could not cleanly backport this to |
bedevere-bot commented Jun 12, 2023
GH-105710 is a backport of this pull request to the 3.12 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 12, 2023
…fields (pythonGH-105686) All fields must be explicitly initialised to prevent manipulation of uninitialised fields in dealloc. Align initialisation order with the layout of the object structs. (cherry picked from commit ca3cc4b) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jun 12, 2023
…Object fields (python#105686) All fields must be explicitly initialised to prevent manipulation of uninitialised fields in dealloc. Align initialisation order with the layout of the object structs. (cherry picked from commit ca3cc4b) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
bedevere-bot commented Jun 12, 2023
GH-105711 is a backport of this pull request to the 3.11 branch. |
ContributorAuthor
erlend-aasland commented Jun 12, 2023
Thanks for the review! |
erlend-aasland added a commit that referenced this pull request Jun 12, 2023
… fields (GH-105686) (#105710) All fields must be explicitly initialised to prevent manipulation of uninitialised fields in dealloc. Align initialisation order with the layout of the object structs. (cherry picked from commit ca3cc4b) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
carljm added a commit to carljm/cpython that referenced this pull request Jun 12, 2023
* main: pythongh-105540: Fix code generator tests (python#105707) pythongh-105375: Explicitly initialise all{Pickler,Unpickler}Object fields (python#105686) pythongh-105331: Change `asyncio.sleep` to raise ``ValueError` for nan (python#105641) Remove support for legacy bytecode instructions (python#105705)
kumaraditya303 pushed a commit that referenced this pull request Jun 13, 2023
… fields (#105686) (#105711) * [3.11] gh-105375: Explicitly initialise all{Pickler,Unpickler}Object fields (#105686) All fields must be explicitly initialised to prevent manipulation of uninitialised fields in dealloc. Align initialisation order with the layout of the object structs. (cherry picked from commit ca3cc4b) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyObject_GC_New() only initialises the object header. All other fields
must be explicitly initialised to prevent manipulation of uninitialised
fields in dealloc.
Align initialisation order with the layout of the object structs.