gh-98040: Fix importbench: use types.ModuleType()#105743
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Replace removed imp.new_module(name) with types.ModuleType(name).
vstinner requested review from brettcannon, ericsnowcurrently, ncoghlan and warsaw as code owners
6 tasks
Contributor
miss-islington commented Jun 13, 2023
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 13, 2023
) Replace removed imp.new_module(name) with types.ModuleType(name). (cherry picked from commit 457a459) Co-authored-by: Victor Stinner <vstinner@python.org>
bedevere-bot commented Jun 13, 2023
GH-105754 is a backport of this pull request to the 3.12 branch. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace removed imp.new_module(name) with types.ModuleType(name).
📚 Documentation preview 📚: https://cpython-previews--105743.org.readthedocs.build/