Skip to content

Conversation

@Yhg1s
Copy link
Member

@Yhg1sYhg1s commented Jun 19, 2023

Fix a regression introduced in GH-101251, causing GzipFile.flush() to not flush the compressor (nor pass along the zip_mode argument).

…h() to not flush the compressor (nor pass along the zip_mode argument).
@Yhg1sYhg1s requested review from ambv and gpsheadJune 19, 2023 11:32
@gpsheadgpshead added the needs backport to 3.12 only security fixes label Jun 19, 2023
@gpsheadgpshead enabled auto-merge (squash) June 19, 2023 16:40
@gpsheadgpshead merged commit 1858db7 into python:mainJun 19, 2023
@miss-islington
Copy link
Contributor

Thanks @Yhg1s for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-105920 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 19, 2023
…onGH-105910) Fix a regression introduced in pythonGH-101251, causing GzipFile.flush() to not flush the compressor (nor pass along the zip_mode argument). (cherry picked from commit 1858db7) Co-authored-by: T. Wouters <thomas@python.org>
@bedevere-botbedevere-bot removed the needs backport to 3.12 only security fixes label Jun 19, 2023
Yhg1s added a commit that referenced this pull request Jun 19, 2023
#105920) GH-105808: Fix a regression introduced in GH-101251 (GH-105910) Fix a regression introduced in GH-101251, causing GzipFile.flush() to not flush the compressor (nor pass along the zip_mode argument). (cherry picked from commit 1858db7) Co-authored-by: T. Wouters <thomas@python.org>
@Yhg1sYhg1s deleted the gzip-flush branch November 22, 2023 15:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Yhg1s@miss-islington@bedevere-bot@gpshead