gh-105927: Deprecate PyWeakref_GetObject() function#106006
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MemberAuthor
vstinner commented Jun 23, 2023
Deprecate PyWeakref_GetObject() and PyWeakref_GET_OBJECT() functions.
vstinnerforce-pushed the deprecate_weakref_getobject branch from cded796 to 5753693Compare Comment on lines +3379 to +3380
| _Py_COMP_DIAG_PUSH | ||
| _Py_COMP_DIAG_IGNORE_DEPR_DECLS |
Contributor
There was a problem hiding this comment.
I did not know these macros; TIL!
MemberAuthor
There was a problem hiding this comment.
It's very useful to write tests on deprecated APIs.
erlend-aasland approved these changes Jun 26, 2023
Member
encukou commented Jun 26, 2023
Why 3.15? I don't see any reason to use the minimum allowed deprecation period here. |
MemberAuthor
vstinner commented Jun 27, 2023
Borrowed references as bad: see the issue for the rationale. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecate PyWeakref_GetObject() and PyWeakref_GET_OBJECT() functions.
📚 Documentation preview 📚: https://cpython-previews--106006.org.readthedocs.build/