Skip to content

gh-106162: fix test_array modifies warning filter#106181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
methane merged 1 commit into from
Jun 28, 2023
Merged

gh-106162: fix test_array modifies warning filter #106181

methane merged 1 commit into from
Jun 28, 2023

Conversation

@methane
Copy link
Member

@methanemethane commented Jun 28, 2023•
edited by bedevere-bot
Loading

@bedevere-botbedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jun 28, 2023
@bedevere-botbedevere-bot mentioned this pull request Jun 28, 2023
Closed
@methane
Copy link
MemberAuthor

methane commented Jun 28, 2023

inada-n@PC-4524 ~/w/p/cpython (fix-test-array-warning-filter)> ./python.exe -m test test_array --fail-env-changed -m test.test_array.ArrayReconstructorTest.test_error Raised RLIMIT_NOFILE: 256 -> 1024 0:00:00 load avg: 1.93 Run tests sequentially 0:00:00 load avg: 1.93 [1/1] test_array == Tests result: SUCCESS == 1 test OK. Total duration: 36 ms Tests result: SUCCESS

sunmy2019
sunmy2019 approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@sunmy2019sunmy2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, clever. I have been always wondering how to apply context manager to a test case.

@methanemethane merged commit a3dd8cc into python:mainJun 28, 2023
@methanemethane deleted the fix-test-array-warning-filter branch June 28, 2023 07:50
@AlexWaygoodAlexWaygood changed the title gh-106162: fix test_array modifies farning filtergh-106162: fix test_array modifies warning filterJun 28, 2023
@methanemethane mentioned this pull request Jul 4, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sunmy2019sunmy2019sunmy2019 approved these changes

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@methane@sunmy2019@bedevere-bot