Skip to content

Conversation

@ghost
Copy link

@ghostghost commented Jun 30, 2023

__index__, __int__, __float__, __complex__ are documented as methods of object, so prepended ~object to reference correctly.


📚 Documentation preview 📚: https://cpython-previews--106278.org.readthedocs.build/

``__index__``, ``__int__``, ``__float__``, ``__complex__`` are methods of ``object``, so prepended `~object` to reference correctly.
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small nits, but looks great overall. Thanks!

F3eQnxN3RriKand others added 3 commits June 30, 2023 23:13
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@AlexWaygoodAlexWaygood added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jun 30, 2023
@AlexWaygoodAlexWaygood changed the title gh-101100: Fix references to object methodsgh-101100: Docs: Fix references to several numeric dundersJun 30, 2023
@AlexWaygoodAlexWaygood self-assigned this Jun 30, 2023
@AlexWaygoodAlexWaygood merged commit a8ae739 into python:mainJun 30, 2023
@miss-islington
Copy link
Contributor

Thanks @F3eQnxN3RriK for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 30, 2023
…honGH-106278) (cherry picked from commit a8ae739) Co-authored-by: F3eQnxN3RriK <drsuaimqjgar@gmail.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-bot
Copy link

GH-106281 is a backport of this pull request to the 3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12 only security fixes label Jun 30, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 30, 2023
…honGH-106278) (cherry picked from commit a8ae739) Co-authored-by: F3eQnxN3RriK <drsuaimqjgar@gmail.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-bot
Copy link

GH-106282 is a backport of this pull request to the 3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Jun 30, 2023
AlexWaygood added a commit that referenced this pull request Jun 30, 2023
…-106278) (#106281) gh-101100: Docs: Fix references to several numeric dunders (GH-106278) (cherry picked from commit a8ae739) Co-authored-by: F3eQnxN3RriK <drsuaimqjgar@gmail.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood added a commit that referenced this pull request Jun 30, 2023
…-106278) (#106282) gh-101100: Docs: Fix references to several numeric dunders (GH-106278) (cherry picked from commit a8ae739) Co-authored-by: F3eQnxN3RriK <drsuaimqjgar@gmail.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@ghost ghost deleted the doc-patch-2 branch June 30, 2023 22:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@miss-islington@bedevere-bot@AlexWaygood