gh-106368: Harden Argument Clinic parser tests#106384
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Also assert parser error messages.
erlend-aasland added skip news needs backport to 3.11 
ContributorAuthor
erlend-aasland commented Jul 3, 2023
I consider this uncontroversial; will merge when CI is green. |
Contributor
miss-islington commented Jul 3, 2023
Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 3, 2023
(cherry picked from commit 648688c) Co-authored-by: Erlend E. Aasland <erlend@python.org>
bedevere-bot commented Jul 3, 2023
GH-106387 is a backport of this pull request to the 3.12 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 3, 2023
(cherry picked from commit 648688c) Co-authored-by: Erlend E. Aasland <erlend@python.org>
bedevere-bot commented Jul 3, 2023
GH-106388 is a backport of this pull request to the 3.11 branch. |
erlend-aasland added a commit that referenced this pull request Jul 3, 2023
erlend-aasland added a commit that referenced this pull request Jul 3, 2023
carljm added a commit to carljm/cpython that referenced this pull request Jul 4, 2023
* main: pythongh-106368: Increase Argument Clinic test coverage (python#106389) pythongh-106320: Fix _PyImport_GetModuleAttr() declaration (python#106386) pythongh-106368: Harden Argument Clinic parser tests (python#106384) pythongh-106320: Remove private _PyImport C API functions (python#106383) pythongh-86085: Remove _PyCodec_Forget() declaration (python#106377) pythongh-106320: Remove more private _PyUnicode C API functions (python#106382) pythongh-104050: Annotate more Argument Clinic DSLParser state methods (python#106376) pythongh-106368: Clean up Argument Clinic tests (python#106373)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also assert parser error messages.