Skip to content

Conversation

@gvanrossum
Copy link
Member

@gvanrossumgvanrossum commented Jul 6, 2023

Also fixed and cleaned up test_capi.test_misc.TestUops, and added a new test proving that EXTENDED_ARG works.

@gvanrossum
Copy link
MemberAuthor

gvanrossum commented Jul 6, 2023

Tests are failing. I'll regroup and see if my EXTENDED_ARG handling is at fault or if it was pre-existing, and then proceed from there. For now, this is another Draft PR, and I'll isolate my test cleanups in a new PR.


UPDATE: Fixed by gh-106492, rebased, undrafted.

@gvanrossumgvanrossum marked this pull request as draft July 6, 2023 20:42
@gvanrossum
Copy link
MemberAuthor

gvanrossum commented Jul 6, 2023

I get the same failure with just Fix and clean up uops and executor API. That makes me think the root problem is pre-existing (since that commit has no C code). I'll see if the address sanitizer will help me debug this.


UPDATE: Yeah, the UOpOptimizer type was missing a tp_dealloc handler. Nasty. Fixing that in gh-106492. Once that's merged I'll rebase and undraft this.

@gvanrossumgvanrossum marked this pull request as ready for review July 6, 2023 22:51
@gvanrossumgvanrossum merged commit e1d45b8 into python:mainJul 6, 2023
@gvanrossumgvanrossum deleted the uops-extended-arg branch July 6, 2023 23:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@gvanrossum@bedevere-bot