Skip to content

gh-105927: PyWeakref_GetRef() returns 1 on success#106561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 2 commits into from
Jul 9, 2023
Merged

gh-105927: PyWeakref_GetRef() returns 1 on success #106561

vstinner merged 2 commits into from
Jul 9, 2023

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commented Jul 9, 2023•
edited by github-actions bot
Loading

PyWeakref_GetRef() now returns 1 on success, and return 0 if the reference is dead.

📚 Documentation preview 📚: https://cpython-previews--106561.org.readthedocs.build/

@vstinner
pythongh-105927: PyWeakref_GetRef() returns 1 on success
3de3579
PyWeakref_GetRef() now returns 1 on success, and return 0 if the reference is dead.
@bedevere-botbedevere-bot mentioned this pull request Jul 9, 2023
Closed
@vstinner
Copy link
MemberAuthor

vstinner commented Jul 9, 2023

PR to update the newly added C API to respect the new C API guidelines: https://devguide.python.org/developer-workflow/c-api/index.html

APIs with lesser and greater results must return 0 for the lesser result, and 1 for the greater result. Consider a lookup function with a three-way return: (...)

cc @erlend-aasland

@vstinnervstinner mentioned this pull request Jul 9, 2023
Merged
@vstinner
Copy link
MemberAuthor

vstinner commented Jul 9, 2023

cc @encukou

serhiy-storchaka
serhiy-storchaka approved these changes Jul 9, 2023
View reviewed changes
@vstinner@serhiy-storchaka
Update Objects/weakrefobject.c
727a655
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@vstinnervstinner enabled auto-merge (squash) July 9, 2023 15:29
@vstinner
Copy link
MemberAuthor

vstinner commented Jul 9, 2023

Thanks for the review @serhiy-storchaka.

@vstinnervstinner merged commit ee46cb6 into python:mainJul 9, 2023
@vstinnervstinner deleted the weakref_getref_success branch July 9, 2023 16:10
@vstinner
Copy link
MemberAuthor

vstinner commented Jul 9, 2023

I updated pythoncapi-compat: python/pythoncapi-compat@d000b55

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner@serhiy-storchaka@bedevere-bot