GH-104909: Split LOAD_ATTR_INSTANCE_VALUE into micro-ops

[markshannon]

• Issue: Split opcodes into micro-ops #104909

[markshannon]

I've change the code generator to allow micro-ops to be shared between instructions.

@gvanrossum Why was that prohibited?

[gvanrossum]

I've change the code generator to allow micro-ops to be shared between instructions.

@gvanrossum Why was that prohibited?

It was just a piece of technical debt, nothing deep. There was some complication and I was initially lazy and put a data structure on the micro-op itself instead of associating it with the connection beween the macro and the op.

[iritkatriel]

There are merge conflicts, and my comment above.

[bedevere-bot]

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

[markshannon]

I have made the requested changes; please review again

[bedevere-bot]

Thanks for making the requested changes!

@iritkatriel: please review the changes made to this pull request.

[bedevere-bot]

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 macOS 3.x has failed when building commit 487861c.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/725/builds/5000) and take a look at the build logs.
4. Check if the failure is related to this commit (487861c) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/725/builds/5000

Failed tests:

• test.test_asyncio.test_ssl
• test_unittest

Failed subtests:

• test_create_connection_ssl_failed_certificate - test.test_asyncio.test_ssl.TestSSL.test_create_connection_ssl_failed_certificate
• test_wait_until_any_call_with_positional - test.test_unittest.testmock.testthreadingmock.TestThreadingMock.test_wait_until_any_call_with_positional

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

424 tests OK.

10 slowest tests:

• test_signal: 4 min 12 sec
• test_concurrent_futures: 2 min 28 sec
• test_multiprocessing_spawn: 1 min 53 sec
• test_multiprocessing_forkserver: 1 min 31 sec
• test_logging: 1 min 7 sec
• test_capi: 41.6 sec
• test_math: 41.5 sec
• test_ssl: 40.8 sec
• test_io: 37.1 sec
• test_socket: 30.8 sec

1 test failed:
test.test_asyncio.test_ssl

18 tests skipped:
test.test_asyncio.test_windows_events
test.test_asyncio.test_windows_utils test_devpoll test_epoll
test_gdb test_ioctl test_launcher test_multiprocessing_fork
test_perf_profiler test_perfmaps test_startfile test_tkinter
test_ttk test_winconsoleio test_winreg test_winsound test_wmi
test_zipfile64

2 re-run tests:
test.test_asyncio.test_ssl test_unittest

Total duration: 6 min 48 sec

Click to see traceback logs

Traceback (most recent call last): File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_asyncio/test_ssl.py", line 454, in test_create_connection_ssl_failed_certificateself.loop.run_until_complete(client(srv.addr)) File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncio/base_events.py", line 664, in run_until_completereturn future.result() ^^^^^^^^^^^^^^^ File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_asyncio/test_ssl.py", line 441, in client reader, writer =await asyncio.open_connection( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncio/streams.py", line 47, in open_connection transport, _ =await loop.create_connection( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncio/base_events.py", line 1126, in create_connection transport, protocol =awaitself._create_connection_transport( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncio/base_events.py", line 1159, in _create_connection_transportawait waiter File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncio/sslproto.py", line 575, in _on_handshake_completeraise handshake_exc File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncio/sslproto.py", line 557, in _do_handshakeself._sslobj.do_handshake() File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/ssl.py", line 917, in do_handshakeself._sslobj.do_handshake() ssl.SSLError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:1015) Traceback (most recent call last): File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_unittest/testmock/testthreadingmock.py", line 179, in test_wait_until_any_call_with_positionalself.assertIn(call(2), something.method_1.mock_calls) AssertionError: call(2) not found in [call(1), call(3)]