Skip to content

gh-104683: Argument Clinic: Modernise parse_special_symbol()#106837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
erlend-aasland merged 8 commits into from
Jul 17, 2023
Merged

gh-104683: Argument Clinic: Modernise parse_special_symbol() #106837

erlend-aasland merged 8 commits into from
Jul 17, 2023

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commented Jul 17, 2023•
edited by bedevere-bot
Loading

@bedevere-botbedevere-bot mentioned this pull request Jul 17, 2023
Closed
7 tasks
@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commented Jul 17, 2023

@AlexWaygood what do you think of this? Is it worth it?

AlexWaygood
AlexWaygood reviewed Jul 17, 2023
View reviewed changes
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't done a thorough review yet, just skimmed, but I think this is a great idea. It makes it much more readable imo, and could also make it easier to create dedicated unit tests for each method

erlend-aasland
erlend-aasland commented Jul 17, 2023
View reviewed changes
@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commented Jul 17, 2023

Haven't done a thorough review yet, just skimmed, but I think this is a great idea. It makes it much more readable imo, and could also make it easier to create dedicated unit tests for each method

Thanks for the preliminary review, though :) BTW, test coverage is already pretty good for the affected lines of code.

@erlend-aaslanderlend-aasland marked this pull request as ready for review July 17, 2023 21:04
AlexWaygood
AlexWaygood reviewed Jul 17, 2023
View reviewed changes
@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commented Jul 17, 2023

Latest remarks addressed in deb05a2. Thanks!

AlexWaygood
AlexWaygood approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great improvement. Thanks!

AlexWaygood
AlexWaygood reviewed Jul 17, 2023
View reviewed changes
@erlend-aasland@AlexWaygood
Apply suggestions from code review
b0ae589
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@erlend-aaslanderlend-aasland enabled auto-merge (squash) July 17, 2023 21:46
@erlend-aaslanderlend-aasland merged commit 00e52ac into python:mainJul 17, 2023
@erlend-aaslanderlend-aasland deleted the clinic/modernise-parse-special-symbol branch August 22, 2023 08:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevnsobolevnsobolevn left review comments

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland@sobolevn@AlexWaygood@bedevere-bot