Skip to content

Conversation

@iritkatriel
Copy link
Member

@iritkatrieliritkatriel commented Jul 20, 2023

pycore_intrinsics.h is currently auto-generated by the build script, which adds complications to the build process but doesn't really buy us anything. This PR defines them in C and exposes through a method in the _opcode module. There are two places where the list of intrinsics is defined before and after this change.

@iritkatrieliritkatriel added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jul 20, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit ef8c521 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jul 20, 2023
Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the process for adding a new intrinsic is now just to add a line to the appropriate table and add a define to pycore_intrinsics.h and update the MAX define there? That's not too tedious.

@iritkatriel
Copy link
MemberAuthor

Some of the refleaks failures look like this:

====================================================================== FAIL: test_extended_arg (test.test_capi.test_misc.TestUops.test_extended_arg) Check EXTENDED_ARG handling in superblock creation ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/test/test_capi/test_misc.py", line 2491, in test_extended_arg self.assertIsNone(ex) AssertionError: <uop_executor object at 0x1c24a50> is not None ---------------------------------------------------------------------- 

@iritkatrieliritkatriel merged commit 9c81fc2 into python:mainJul 20, 2023
@iritkatrieliritkatriel deleted the intrinsics branch July 25, 2023 18:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@iritkatriel@bedevere-bot@gvanrossum